Skip to content

B5.2: Add bounded split-output relay and source marks - #78

Open
omry wants to merge 1 commit into
pr77from
pr78
Open

omry wants to merge 1 commit into
pr77from
pr78

Conversation

@omry

@omry omry commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Relay separate stdout and stderr FIFOs through the existing ordered terminal writer. Public source marks identify exact logical byte ranges in the single raw output stream. Preserve interrupted output and resume each live reader after its complete admitted chunk is sent, including interruption at the final write boundary.

Validation: all 15 repository and native checks pass on the current candidate, including Go race coverage and genuine Linux amd64 Bash 5.2.15, 5.2.37 and 5.3.9. A focused scheduling overlay verifies completed-write interruption for both streams and both delivery paths; the original implementation fails all four cases. Those deterministic cases skip without the overlay. ARM64 was compiled only.

B5.3 owns production split start, resize and cleanup integration, including cleanup-before-keepalive closure, dual EOF, resource removal and final result barriers. This change supplies the isolated transport primitive.


Relay separate stdout and stderr FIFOs through the existing ordered terminal writer. Public source marks identify exact logical byte ranges in the single raw output stream. Preserve interrupted output and resume each live reader after its complete admitted chunk is sent, including interruption at the final write boundary.

Validation: all 15 repository and native checks pass on the current candidate, including Go race coverage and genuine Linux amd64 Bash 5.2.15, 5.2.37 and 5.3.9. A focused scheduling overlay verifies completed-write interruption for both streams and both delivery paths; the original implementation fails all four cases. Those deterministic cases skip without the overlay. ARM64 was compiled only.

B5.3 owns production split start, resize and cleanup integration, including cleanup-before-keepalive closure, dual EOF, resource removal and final result barriers. This change supplies the isolated transport primitive.
@omry
omry changed the base branch from main to pr77 October 18, 2026 10:17
@omry
omry added this pull request to stack #44 October 18, 2026 10:18
@gitar-bot

gitar-bot Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Adding split stdout/stderr FIFO relay and source marks changes session output delivery; interruption or attribution errors could lose or mislabel command output.

Adds a bounded split-output relay that feeds separate stdout and stderr FIFOs through the existing ordered terminal writer, with public source marks identifying exact logical byte ranges in the raw output stream. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:0fc07a99183b38a74a14cdc75e8642a583e3ea96e702eedf1f31bde133764a91",
    "evidence": {
      "attestations": [
        {
          "closure_identity": "sha256:c5cb4a283add8970141c202f4164cdc2243760e90d27312ba9b95b8baa519733",
          "document_identity": "sha256:9089495c887132f510fc0e55d960cf0395b1ea56d135de694095f98466716833",
          "sidecar_identity": "sha256:8c4c8a483925b2659899930058caccf7f6f0873585af40280d3cd97376791cc4"
        },
        {
          "closure_identity": "sha256:c5cb4a283add8970141c202f4164cdc2243760e90d27312ba9b95b8baa519733",
          "document_identity": "sha256:98b4fdc917f0807c30de93d32cf1f4b0cc32a8bb68d1c1b3d8bf1cdb267af525",
          "sidecar_identity": "sha256:52adcd1fbcefbdc34b749d4b249b37aef8959e93a9413e61b5bb0aaa4929a80b"
        },
        {
          "closure_identity": "sha256:c5cb4a283add8970141c202f4164cdc2243760e90d27312ba9b95b8baa519733",
          "document_identity": "sha256:9fc71791194e4e7e20cadb4c71d4900309bb4b40863759fb6de5bb6f8996a8f8",
          "sidecar_identity": "sha256:7910c7b9ead462b1ee566a56ed977555fee3cd3446067272d530e4dc48fbf958"
        },
        {
          "closure_identity": "sha256:c5cb4a283add8970141c202f4164cdc2243760e90d27312ba9b95b8baa519733",
          "document_identity": "sha256:f064097e51591052bd1ae470bcb5cd8e8a8265df4089651fecba2a32159b0c24",
          "sidecar_identity": "sha256:a88b3f115e0723f633eed27a9ee8b30cfe16773bda3ff1ee41aa1ac6e8edff86"
        }
      ],
      "candidate_revision_fingerprint": "sha256:0fc07a99183b38a74a14cdc75e8642a583e3ea96e702eedf1f31bde133764a91",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Envoy Go",
          "run_id": 117649624422
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 117649628895
        },
        {
          "conclusion": "SUCCESS",
          "name": "Package build",
          "run_id": 117649624531
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python tests",
          "run_id": 117649624279
        },
        {
          "conclusion": "SUCCESS",
          "name": "Recording integration",
          "run_id": 117649624435
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website docs",
          "run_id": 117649624467
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:d9ac301f177cc74f4f929110494d1febfac651116b5fd504901b029383b54952",
      "review_request": {
        "body_digest": "sha256:903f9e3fd288162ed4bd8b35d546c96a19f44375f7fdbcf63f6001856bebe9fb",
        "id": 6248851539
      },
      "review_result": {
        "body_digest": "sha256:328b975e7597468ca74e9819137af6ceb84b6a2f3063484e77f8be9b21d80395",
        "id": 6248887371
      }
    },
    "evidence_fingerprint": "sha256:d033e97d00cae2bc04b82a46ec89c0b080e976f6169b8fc745558878b010092e",
    "head_sha": "e988eab87e8f2e3384ef1f83459f1652883628e4",
    "operation_identity": "sha256:d9ac301f177cc74f4f929110494d1febfac651116b5fd504901b029383b54952",
    "review_request_id": 6248851539,
    "review_result_id": 6248887371,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:0fc07a99183b38a74a14cdc75e8642a583e3ea96e702eedf1f31bde133764a91",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Envoy Go",
      "run_id": 117649624422
    },
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 117649628895
    },
    {
      "conclusion": "SUCCESS",
      "name": "Package build",
      "run_id": 117649624531
    },
    {
      "conclusion": "SUCCESS",
      "name": "Python tests",
      "run_id": 117649624279
    },
    {
      "conclusion": "SUCCESS",
      "name": "Recording integration",
      "run_id": 117649624435
    },
    {
      "conclusion": "SUCCESS",
      "name": "Website docs",
      "run_id": 117649624467
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Envoy Go",
          "run_id": 117649624422,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/omegaflow/actions/runs/39118681165/job/117649624422"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 117649628895,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/omegaflow/runs/117649628895"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Package build",
          "run_id": 117649624531,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/omegaflow/actions/runs/39118681165/job/117649624531"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python tests",
          "run_id": 117649624279,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/omegaflow/actions/runs/39118681165/job/117649624279"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Recording integration",
          "run_id": 117649624435,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/omegaflow/actions/runs/39118681165/job/117649624435"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website docs",
          "run_id": 117649624467,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/omegaflow/actions/runs/39118681165/job/117649624467"
        }
      ],
      "head_sha": "e988eab87e8f2e3384ef1f83459f1652883628e4",
      "id": "sha256:e6e28b75c9ce54ab073fe265b4b8c4c99392cfcedd22e99a7e691c938d23cda2",
      "required_checks": [
        "Envoy Go",
        "Gitar",
        "Package build",
        "Python tests",
        "Recording integration",
        "Website docs"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr77",
    "base_sha": "767f874e08d68583f6a0b3df7ec8e29058167559",
    "body_digest": "sha256:32bd8a47919b65a072bbbf1f5a43fc0d73b40fb4d913d9a8ddc8b4031b5f5a4f",
    "diff_digest": "sha256:dbb87d68e4cc5c7146be5a3844f6f490030ba60a3bcbea4a322e1c3d1c1342c9",
    "head_ref": "pr78",
    "head_sha": "e988eab87e8f2e3384ef1f83459f1652883628e4",
    "pr": 78,
    "repository": "omry/omegaflow",
    "scope_authority": [
      {
        "digest": "sha256:9fc71791194e4e7e20cadb4c71d4900309bb4b40863759fb6de5bb6f8996a8f8",
        "path": "docs/design/envoy-protocol-v1.md"
      },
      {
        "digest": "sha256:9089495c887132f510fc0e55d960cf0395b1ea56d135de694095f98466716833",
        "path": "docs/design/omegaflow-envoy-design.md"
      },
      {
        "digest": "sha256:f064097e51591052bd1ae470bcb5cd8e8a8265df4089651fecba2a32159b0c24",
        "path": "docs/design/reploy-environments-design.md"
      },
      {
        "digest": "sha256:98b4fdc917f0807c30de93d32cf1f4b0cc32a8bb68d1c1b3d8bf1cdb267af525",
        "path": "docs/design/reploy-integration-implementation-plan.md"
      }
    ],
    "title_digest": "sha256:34a73b0788cdbec6594a66380afcba7c0c43502eb8ccce78bd765d8334d8b9a3"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-18T10:17:44Z",
      "base_ref": "pr77",
      "base_sha": "767f874e08d68583f6a0b3df7ec8e29058167559",
      "body_digest": "sha256:903f9e3fd288162ed4bd8b35d546c96a19f44375f7fdbcf63f6001856bebe9fb",
      "created_at": "2026-10-18T10:39:22Z",
      "head_sha": "e988eab87e8f2e3384ef1f83459f1652883628e4",
      "id": 6248851539,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr77",
      "base_sha": "767f874e08d68583f6a0b3df7ec8e29058167559",
      "body_digest": "sha256:328b975e7597468ca74e9819137af6ceb84b6a2f3063484e77f8be9b21d80395",
      "commit_id": "e988eab87e8f2e3384ef1f83459f1652883628e4",
      "id": 6248887371,
      "inline_message_ids": [],
      "request_comment_id": 6248851539,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-18T10:43:33Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:0fc07a99183b38a74a14cdc75e8642a583e3ea96e702eedf1f31bde133764a91",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:dbb87d68e4cc5c7146be5a3844f6f490030ba60a3bcbea4a322e1c3d1c1342c9",
      "finding_ids": [],
      "invariants": [
        "Bounded independent stdout/stderr reader ownership and one ordered raw terminal stream",
        "Exact sender-marked logical stream bytes and lossless interruption recovery",
        "Production split integration and cleanup completion remain with B5.3"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "e988eab87e8f2e3384ef1f83459f1652883628e4",
      "review_observation_id": null,
      "review_request_id": 6248851539,
      "review_result_id": 6248887371,
      "reviewed_head": "e988eab87e8f2e3384ef1f83459f1652883628e4",
      "root_cause": "Fresh exact-head remote review clean; all6 CI and16 full local checks pass. No PR source correction or synchronization required.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 18, 2026 10:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T10:43:35.120086Z e988eab Manual request
🔒 Security Review ✅ Completed 2026-10-18T10:38:19.817125Z e988eab Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review e988eab

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: e988eab87e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant