Skip to content

fix(chart): pin the Bitnami images in the base values - #28

Merged
leandrolerena merged 1 commit into
mainfrom
fix/default-values-live-images
Nov 9, 2026
Merged

leandrolerena merged 1 commit into
mainfrom
fix/default-values-live-images

Conversation

@leandrolerena

Copy link
Copy Markdown
Member

What was wrong

Found by check VER-27 of the 2026-11-09 network-zones release test, against main at cc57cce.

With the base values alone (helm template neops charts/neops), the Bitnami subcharts render their own image defaults:

  • docker.io/bitnami/elasticsearch:8.18.0-debian-12-r2 and docker.io/bitnami/os-shell:12-debian-12-r43: docker manifest inspect returns "no such manifest", so Elasticsearch ends in ImagePullBackOff.
  • bitnami/postgresql:latest and bitnami/redis:latest: these still resolve, but they float.

Only charts/neops/values-kind.yaml switched to bitnamilegacy/* and set global.security.allowInsecureImages. Any other environment file layered on the base values got the dead images.

What this changes

  • The bitnamilegacy/* pins for postgresql, redis, elasticsearch (with its sysctlImage) and minio, plus global.security.allowInsecureImages: true, move from charts/neops/values-kind.yaml into charts/neops/values.yaml. Each pin now lives in one place.
  • Adds a pin for the MinIO console image (bitnamilegacy/minio-object-browser:2.0.2-debian-12-r3). It was unpinned before, including in KIND.
  • README.md says that the base values carry the image pins.

The rendered KIND release is unchanged.

Upgrade note for releases outside KIND

A release installed from the base values was running bitnami/postgresql:latest (Postgres 18.6.0) and bitnami/redis:latest (Redis 8.10.3). These pins are the newest tags bitnamilegacy publishes, Postgres 17.6.0 and Redis 8.2.1, which is what the KIND loop already runs. A release whose Postgres data directory was already initialised on 18 must not take this pin as is. Override postgresql.image in its environment file instead, because Postgres 17 cannot open an 18 data directory.

Left unchanged on purpose

The finding also flagged quay.io/zebbra/neops-secure-gateway:cutting-edge in charts/neops/values-kind.yaml, which is not on Quay. That is expected and stays as it is. The KIND loop builds that tag locally and loads it into the cluster: the workspace's deploy-cutting-edge sets TAG ?= cutting-edge, and the secure-gateway Makefile builds quay.io/zebbra/neops-secure-gateway:$(TAG).

How it was verified

This repo's CI only runs the PR-label check, so everything below was run by hand:

  • helm dependency build and helm lint on both the base values and values-kind.yaml. Lint passes.
  • helm template with the base values renders only bitnamilegacy/* images for postgresql, redis, elasticsearch and os-shell, and the insecure-images check raises no error.
  • helm template with --set minio.enabled=true --set neops-storage.enabled=true, with and without -f charts/neops/values-kind.yaml, also renders bitnamilegacy for minio and minio-object-browser. That includes the provisioning job when minio.provisioning.enabled is set.
  • Rendering with values-kind.yaml gives the same images before and after the change.
  • docker manifest inspect resolves all six pinned images: elasticsearch, os-shell, postgresql, redis, minio and minio-object-browser.

Not verified

  • No deploy. Nobody installed or upgraded a release with this chart, so pod start and image pulls in a real cluster are untested.
  • Nothing in CI guards these pins. If a future subchart bump renames sysctlImage or console.image, the chart would silently fall back to the dead upstream tags.

The base values left the Bitnami charts on their own image defaults:
docker.io/bitnami/elasticsearch:8.18.0-debian-12-r2 and
os-shell:12-debian-12-r43 no longer exist, and postgresql/redis float on
:latest. Only values-kind.yaml swapped to bitnamilegacy/*, so any other
environment file hit ImagePullBackOff on Elasticsearch.

Move the bitnamilegacy pins and global.security.allowInsecureImages from
values-kind.yaml into values.yaml, and pin the MinIO console image too.
The KIND render is unchanged.
@leandrolerena leandrolerena added the pr-bugfix PR introduces a bugfix label Nov 9, 2026
@leandrolerena leandrolerena self-assigned this Nov 9, 2026
@leandrolerena
leandrolerena merged commit 1099f5a into main Nov 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix PR introduces a bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant