Repository navigation
fix(chart): pin the Bitnami images in the base values - #28
Merged
Merged
Conversation
The base values left the Bitnami charts on their own image defaults: docker.io/bitnami/elasticsearch:8.18.0-debian-12-r2 and os-shell:12-debian-12-r43 no longer exist, and postgresql/redis float on :latest. Only values-kind.yaml swapped to bitnamilegacy/*, so any other environment file hit ImagePullBackOff on Elasticsearch. Move the bitnamilegacy pins and global.security.allowInsecureImages from values-kind.yaml into values.yaml, and pin the MinIO console image too. The KIND render is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Found by check VER-27 of the 2026-11-09 network-zones release test, against
mainatcc57cce.With the base values alone (
helm template neops charts/neops), the Bitnami subcharts render their own image defaults:docker.io/bitnami/elasticsearch:8.18.0-debian-12-r2anddocker.io/bitnami/os-shell:12-debian-12-r43:docker manifest inspectreturns "no such manifest", so Elasticsearch ends in ImagePullBackOff.bitnami/postgresql:latestandbitnami/redis:latest: these still resolve, but they float.Only
charts/neops/values-kind.yamlswitched tobitnamilegacy/*and setglobal.security.allowInsecureImages. Any other environment file layered on the base values got the dead images.What this changes
bitnamilegacy/*pins for postgresql, redis, elasticsearch (with itssysctlImage) and minio, plusglobal.security.allowInsecureImages: true, move fromcharts/neops/values-kind.yamlintocharts/neops/values.yaml. Each pin now lives in one place.bitnamilegacy/minio-object-browser:2.0.2-debian-12-r3). It was unpinned before, including in KIND.README.mdsays that the base values carry the image pins.The rendered KIND release is unchanged.
Upgrade note for releases outside KIND
A release installed from the base values was running
bitnami/postgresql:latest(Postgres 18.6.0) andbitnami/redis:latest(Redis 8.10.3). These pins are the newest tagsbitnamilegacypublishes, Postgres 17.6.0 and Redis 8.2.1, which is what the KIND loop already runs. A release whose Postgres data directory was already initialised on 18 must not take this pin as is. Overridepostgresql.imagein its environment file instead, because Postgres 17 cannot open an 18 data directory.Left unchanged on purpose
The finding also flagged
quay.io/zebbra/neops-secure-gateway:cutting-edgeincharts/neops/values-kind.yaml, which is not on Quay. That is expected and stays as it is. The KIND loop builds that tag locally and loads it into the cluster: the workspace'sdeploy-cutting-edgesetsTAG ?= cutting-edge, and the secure-gatewayMakefilebuildsquay.io/zebbra/neops-secure-gateway:$(TAG).How it was verified
This repo's CI only runs the PR-label check, so everything below was run by hand:
helm dependency buildandhelm linton both the base values andvalues-kind.yaml. Lint passes.helm templatewith the base values renders onlybitnamilegacy/*images for postgresql, redis, elasticsearch and os-shell, and the insecure-images check raises no error.helm templatewith--set minio.enabled=true --set neops-storage.enabled=true, with and without-f charts/neops/values-kind.yaml, also rendersbitnamilegacyfor minio and minio-object-browser. That includes the provisioning job whenminio.provisioning.enabledis set.values-kind.yamlgives the same images before and after the change.docker manifest inspectresolves all six pinned images: elasticsearch, os-shell, postgresql, redis, minio and minio-object-browser.Not verified
sysctlImageorconsole.image, the chart would silently fall back to the dead upstream tags.