Repository navigation
docs(readme): keep a pre-pin release on its own Postgres and Redis images - #29
Open
leandrolerena wants to merge 2 commits into
Open
leandrolerena wants to merge 2 commits into
leandrolerena wants to merge 2 commits into
Conversation
…ages Releases installed from the base values before d725f56 ran the charts' default bitnami/postgresql:latest (18.6.0 today) and bitnami/redis:latest (8.10.3). Upgrading them onto the bitnamilegacy pins starts Postgres 17 on an 18 data directory, which Postgres refuses, and Redis 8.2 on a newer RDB file. bitnamilegacy has no Postgres 18, so document how to find the running image and pin its digest in the environment values file, and point the postgresql and redis pins in values.yaml at that section. The rendered output of values.yaml and values-kind.yaml is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
#28 pinned the Bitnami images in
charts/neops/values.yamltobitnamilegacy/postgresql:17.6.0-debian-12-r4andbitnamilegacy/redis:8.2.1-debian-12-r0. Before that, the base values set noimage:for either subchart, so a release installed from them ran the vendored charts' default (charts/neops/charts/postgresql-18.8.17.tgzandredis-28.0.15.tgzboth default totag: latest). Today that isbitnami/postgresql:latest= 18.6.0 andbitnami/redis:latest= 8.10.3.Running
helm upgradeon such a release with the new pins starts Postgres 17 on an 18 data directory, which Postgres refuses to open. It also starts Redis 8.2 on an RDB file a newer Redis wrote, which it may refuse. bitnamilegacy publishes no Postgres 18 and no Redis newer than 8.2.1, so there is no pin to move to. KIND releases (values-kind.yaml) had the pins all along and are not affected.What changes
Docs and comments only:
README.md: a new section, "Upgrading a release installed before the Bitnami pins". It explains the risk, gives akubectlcommand that reads the image and imageID the Postgres and Redis pods run, and shows how to keep exactly that image by pinning its digest in the environment values file. It also says that moving such a release onto Postgres 17 needs a dump and restore, which the chart does not do.charts/neops/values.yaml: comments on thepostgresql.imageandredis.imagepins that point to that section.How it was verified
This repo's CI only checks the PR label, so everything below was run by hand. Nothing was deployed and no cluster was touched.
helm dependency buildandhelm lintpass for bothvalues.yamlandvalues-kind.yaml.helm templateoutput before and after this change is identical for both values files, apart from randomly generated secrets.registry-1.docker.io/bitnami/postgresql@sha256:...andregistry-1.docker.io/bitnami/redis@sha256:...: the subchart'scommon.images.imagedrops the tag when a digest is set.global.security.allowInsecureImages: true(charts/neops/values.yaml:20) keeps Bitnami's modified-image check from blocking it.docker manifest inspectconfirms the four pinned bitnamilegacy images exist. Thebitnami/*:latestimage labels confirm 18.6.0 and 8.10.3.Not verified
kubectl ... -o jsonpathcommand was not run against a cluster.helm upgradefrom a release that ranlatestwas attempted, with or without the digest override.bitnami/*:latestcan still be pulled. Bitnami's free repositories now keep onlylatest, so an operator who relies on that digest may want to mirror it into their own registry.neopsand theneops-pod prefix, like the rest ofREADME.md. The last paragraph explains the<release>form.For the maintainer
The release notes for #28 do not warn about this downgrade. Relabel that PR
pr-breaking-change, or relabel this one, if they should.This repo is not part of docs.neops.io, so this change does not reach the public docs site.