Repository navigation
fix(remote): guard stash for remote repositories; check branches via ListBranches - #690
Merged
Ziinc merged 1 commit intoOct 1, 2026
Conversation
…ListBranches - Every stash wrapper is asserted local. Stashes are gist commits in this machine's jj store, so they have no remote equivalent yet. The "Stash all" button and the command palette's stash entry are hidden for a remote repository. - checkBranchExists routes a remote repository through the typed ListBranches read instead of running jj_check_branch_exists on the remote path locally. Remote-tracking refs are not reported yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MbYSPHBRmDYwPJpHG33Y4t
Ziinc
force-pushed
the
claude/prd-gaps-remote-path-guards-11
branch
from
September 30, 2026 09:27
8cb9e93 to
1e17581
Compare
Base automatically changed from
claude/prd-gaps-remote-path-guards-10
to
claude/prd-gaps-remote-path-guards-5
October 1, 2026 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #688. Removes 8 entries from
KNOWN_UNGUARDED.stashWorkspaceChanges,stashCommit,listStashes,deleteStash,applyStash,getStashDiff,exportStashGitPatchassertLocalOperation, which rejects withunsupported: Stashing is not available…checkBranchExists(new-workspace dialog,useWorkspaceDialogEffects)jj_check_branch_existson the remote path locallytransportCheckBranchExists→ typedListBranches;remote_existsis alwaysfalsefor nowFileSidebarpasses noonStashAll) and the command palette's "Stash" entry are hidden for a remote repository. The per-commit "Stash" menu item is still shown and fails with an error toast. Hiding it needs a prop change inCommitDiffViewer, which I left for the sibling remote-mutations work that adds a typed stash route.Checks
checkBranchExistsrouting test,remote-path-guards.test.tswith the shrunk list; full unit suite (826 passed)npm run check,lint,check:format🤖 Generated with Claude Code
https://claude.ai/code/session_01MbYSPHBRmDYwPJpHG33Y4t
Generated by Claude Code