Skip to content

fix(remote): skip git-remote and gh PR status reads for remote repositories - #691

Merged
Ziinc merged 1 commit into
claude/prd-gaps-remote-path-guards-5from
claude/prd-gaps-remote-path-guards-12
Oct 1, 2026
Merged

Ziinc merged 1 commit into
claude/prd-gaps-remote-path-guards-5from
claude/prd-gaps-remote-path-guards-12

Conversation

@Ziinc

@Ziinc Ziinc commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #690. Removes 12 entries from KNOWN_UNGUARDED.

Wrapper Before, for a remote path After
getGitRemoteUrl (useGitRemoteInfo) get_git_remote_url on a local dir at the remote path (github.rs) null
getPrChecksViaGh, getPrInfoViaGh ran gh in that local dir null
startPrStatusPolling, stopPrStatusPolling, refreshPrStatuses, refreshPrBranchStatus Rust poller ran gh against the remote path no-op
listCachedPrStatuses, listCachedPrCiStatuses, getCachedPrInfo, getCachedPrCiStatus cache keyed by the raw remote path {} / null
openOrCreateWorkspaceFromPr local jj mutation at the remote path assertLocalOperation
localReadOr(repoPath, empty, read) (new src/lib/local-only.ts) returns empty for a remote repository. Callers already treat "no remote / no PR" as a normal state, so no UI change is needed. The sibling remote-mutations PR adds typed PR and git-remote reads and can swap these for routes.

Checks

…tories

getGitRemoteUrl, getPrChecksViaGh and the PR-status cache/poller wrappers
ran `git`/`gh` against a local directory at the remote path. For a remote
repository they now return empty results through `localReadOr`, and the
poller never starts. openOrCreateWorkspaceFromPr is asserted local. The
sibling remote-mutations work adds typed PR and git-remote reads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MbYSPHBRmDYwPJpHG33Y4t
@Ziinc
Ziinc force-pushed the claude/prd-gaps-remote-path-guards-12 branch from a736f7e to da79c6a Compare September 30, 2026 09:28
Base automatically changed from claude/prd-gaps-remote-path-guards-11 to claude/prd-gaps-remote-path-guards-5 October 1, 2026 07:44
@Ziinc
Ziinc merged commit da79c6a into claude/prd-gaps-remote-path-guards-5 Oct 1, 2026
15 checks passed
@Ziinc
Ziinc deleted the claude/prd-gaps-remote-path-guards-12 branch October 1, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants