Skip to content

refactor(remote): remove the unreachable legacy "Open via SSH" dialog #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ziinc merged 1 commit into from
Oct 1, 2026
Merged

refactor(remote): remove the unreachable legacy "Open via SSH" dialog #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 0 additions & 194 deletions src/components/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
acknowledgeAgentDispatch,
addPromptHistory,
archiveWorkspace,
buildExplicitAliasSshEndpoint,
checkAndRebaseWorkspaces,
createSession,
deleteWorkspace,
Expand All @@ -46,9 +45,6 @@ import {
listWorkspaceStatuses,
moveWorkspaceChanges,
readLocalSshPublicKey,
remoteCloneRepoOverSsh,
remoteOpenRepoOverSsh,
remoteProbeRepoOverSsh,
resolveSshConfigAlias,
selectFolder,
setSetting,
Expand Down Expand Up @@ -221,14 +217,6 @@ import {
AlertDialogTitle,
} from "./ui/alert-dialog";
import { Button } from "./ui/button";
import {
Dialog,
DialogContent,
DialogDescription,
DialogHeader,
DialogTitle,
} from "./ui/dialog";
import { Input } from "./ui/input";
import { SidebarInset, SidebarProvider } from "./ui/sidebar";
import { useToast } from "./ui/toast";
import { WorkspacePicker } from "./WorkspacePicker";
Expand Down Expand Up @@ -360,15 +348,7 @@ export const Dashboard: React.FC<DashboardProps> = ({
const [terminalSessionSummaries, setTerminalSessionSummaries] = useState<
TerminalSessionSummary[]
>([]);
const [showRemoteSshDialog, setShowRemoteSshDialog] = useState(false);
const [remoteSshHost, setRemoteSshHost] = useState("");
const [remoteSshPath, setRemoteSshPath] = useState("~/src/project");
const [remoteSshRepoUrl, setRemoteSshRepoUrl] = useState("");
const [remoteSshNeedsClone, setRemoteSshNeedsClone] = useState(false);
const [remoteSshSubmitting, setRemoteSshSubmitting] = useState(false);
const [remoteSshStage, setRemoteSshStage] = useState("");
const [remoteSshHosts, setRemoteSshHosts] = useState<string[]>([]);
const [remoteSshFingerprint, setRemoteSshFingerprint] = useState("");
const [activeRemoteRepo, setActiveRemoteRepo] =
useState<RemoteRepository | null>(null);

Expand Down Expand Up @@ -1747,86 +1727,6 @@ export const Dashboard: React.FC<DashboardProps> = ({
};
}, [repoPath, remoteSshEnabled]);

const rememberRemoteHost = async (host: string) => {
const raw = await getSetting("remote_ssh_recent_hosts").catch(() => null);
const existing: string[] = raw ? JSON.parse(raw) : [];
const next = [host, ...existing.filter((h) => h !== host)].slice(0, 5);
await setSetting("remote_ssh_recent_hosts", JSON.stringify(next));
};

const handleSubmitRemoteSsh = async () => {
const host = remoteSshHost.trim();
const remotePath = remoteSshPath.trim();
const repoUrl = remoteSshRepoUrl.trim();
const fingerprint = remoteSshFingerprint.trim();
if (!host || !remotePath || !fingerprint) {
addToast({
title: "Remote SSH details required",
description:
"Enter an SSH host alias, remote directory, and the expected host-key fingerprint.",
type: "error",
});
return;
}

setRemoteSshSubmitting(true);
try {
setRemoteSshStage("Resolving SSH alias and pinning host trust...");
// Trust is explicit and pinned here, not inferred from ~/.ssh/known_hosts:
// the alias is resolved to hostname/port/user, then paired with the
// fingerprint the user just supplied to build a native SshEndpoint whose
// HostKeyVerifier enforces exactly that fingerprint (never a system ssh
// subprocess, never StrictHostKeyChecking=no).
const identities = await listLocalSshIdentities().catch(() => []);
const endpoint = await buildExplicitAliasSshEndpoint({
endpointId: `alias:${host}`,
alias: host,
expectedFingerprint: fingerprint,
hostKeyAlgorithm: "unknown",
keyReference: identities[0]?.reference ?? "id_ed25519",
});

setRemoteSshStage("Inspecting repository...");
const probe = await remoteProbeRepoOverSsh(endpoint, remotePath);
let remoteRepo = probe.is_repo
? await remoteOpenRepoOverSsh(endpoint, remotePath)
: null;

if (!remoteRepo) {
if (!repoUrl) {
setRemoteSshNeedsClone(true);
setRemoteSshStage("Repository not found. Enter a Git URL to clone.");
return;
}
setRemoteSshStage("Cloning and inspecting repository...");
remoteRepo = await remoteCloneRepoOverSsh(
endpoint,
repoUrl,
remotePath,
);
}

await rememberRemoteHost(host);
await setSetting("last_opened_remote_repo", JSON.stringify(remoteRepo));
setActiveRemoteRepo(remoteRepo);
setShowRemoteSshDialog(false);
addToast({
title: "Remote SSH repository ready",
description: `${remoteRepo.display_name} is ready for SSH terminal sessions.`,
type: "success",
});
} catch (error) {
addToast({
title: "Remote SSH failed",
description: error instanceof Error ? error.message : String(error),
type: "error",
});
} finally {
setRemoteSshSubmitting(false);
setRemoteSshStage("");
}
};

// Consolidate all Tauri event listeners
useEffect(() => {
const listeners = [
Expand Down Expand Up @@ -2814,98 +2714,6 @@ export const Dashboard: React.FC<DashboardProps> = ({
pointerEvents: isSessionView ? "auto" : "none",
};

const remoteSshDialog = (
<Dialog open={showRemoteSshDialog} onOpenChange={setShowRemoteSshDialog}>
<DialogContent>
<DialogHeader>
<DialogTitle>Open via SSH</DialogTitle>
<DialogDescription>
Use an SSH host alias from your config and a remote repository path.
</DialogDescription>
</DialogHeader>
<div className="flex flex-col gap-3">
<label className="flex flex-col gap-1">
<span className="text-sm font-medium">SSH host</span>
<Input
value={remoteSshHost}
onChange={(event) => setRemoteSshHost(event.target.value)}
placeholder="my-server"
list="remote-ssh-hosts"
/>
<datalist id="remote-ssh-hosts">
{remoteSshHosts.map((host) => (
<option key={host} value={host} />
))}
</datalist>
</label>
<label className="flex flex-col gap-1" htmlFor="remote-ssh-path">
<span className="text-sm font-medium">Remote directory</span>
<Input
id="remote-ssh-path"
value={remoteSshPath}
onChange={(event) => setRemoteSshPath(event.target.value)}
placeholder="~/src/project"
/>
</label>
{remoteSshNeedsClone && (
<label
className="flex flex-col gap-1"
htmlFor="remote-ssh-repo-url"
>
<span className="text-sm font-medium">
Git URL (repository not found remotely)
</span>
<Input
id="remote-ssh-repo-url"
value={remoteSshRepoUrl}
onChange={(event) => setRemoteSshRepoUrl(event.target.value)}
placeholder="git@github.com:org/repo.git"
/>
</label>
)}
<label
className="flex flex-col gap-1"
htmlFor="remote-ssh-fingerprint"
>
<span className="text-sm font-medium">
Expected host-key fingerprint
</span>
<Input
id="remote-ssh-fingerprint"
className="font-mono text-xs"
value={remoteSshFingerprint}
onChange={(event) => setRemoteSshFingerprint(event.target.value)}
placeholder="SHA256:..."
/>
<span className="text-xs text-muted-foreground">
Treq pins this fingerprint and never infers trust from your local
SSH configuration or known_hosts; a changed key is always
rejected.
</span>
</label>
{remoteSshStage && (
<p className="text-sm text-muted-foreground">{remoteSshStage}</p>
)}
</div>
<div className="flex justify-end gap-2">
<Button
variant="outline"
onClick={() => setShowRemoteSshDialog(false)}
disabled={remoteSshSubmitting}
>
Cancel
</Button>
<Button
onClick={() => void handleSubmitRemoteSsh()}
disabled={remoteSshSubmitting}
>
{remoteSshSubmitting ? "Connecting..." : "Open via SSH"}
</Button>
</div>
</DialogContent>
</Dialog>
);

const remoteSetupDialog = (
<RemoteSetupDialog
open={showRemoteSetupDialog}
Expand Down Expand Up @@ -2988,7 +2796,6 @@ export const Dashboard: React.FC<DashboardProps> = ({
/>
{explicitEndpointPathForm}
{remoteSetupDialog}
{remoteSshDialog}
<RemoteAmbiguousMutationDialog />
</>
) : (
Expand Down Expand Up @@ -3555,7 +3362,6 @@ export const Dashboard: React.FC<DashboardProps> = ({
onSelect={handleOpenSession}
/>
{remoteSetupDialog}
{remoteSshDialog}
<RemoteAmbiguousMutationDialog />
{activeSshEndpoint && activeRepository?.canonicalPath && (
<RemoteTerminalDialog
Expand Down
Loading