Skip to content

refactor(remote): remove the unreachable legacy "Open via SSH" dialog - #667

Merged
Ziinc merged 1 commit into
claude/prd-gaps-remote-path-guardsfrom
claude/prd-gaps-remote-path-guards-4
Oct 1, 2026
Merged

Ziinc merged 1 commit into
claude/prd-gaps-remote-path-guardsfrom
claude/prd-gaps-remote-path-guards-4

Conversation

@Ziinc

@Ziinc Ziinc commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #662.
This PR only deletes code (194 lines, all in Dashboard.tsx). Since #662, nothing opens the legacy alias dialog, so this removes:

  • handleSubmitRemoteSsh, which stored a RemoteRepository with no endpoint and built its endpoint from identities[0], ignoring the registered identity
  • rememberRemoteHost and the dialog's eight state hooks
  • the remoteSshDialog JSX and its two render sites, plus the now-unused Dialog* and Input imports
    remoteSshHosts stays because it still feeds the setup dialog's alias suggestions.
    Follow-up I did not do here: the TS wrappers remoteProbeRepoOverSsh, remoteOpenRepoOverSsh and remoteCloneRepoOverSsh, and their Tauri commands, have no app caller now. Lint and knip still pass.

Checks

Alias mode now registers a trust-pinned endpoint, so nothing opens the
legacy dialog. That dialog stored endpoint-less repositories and ignored
the registered identity.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MbYSPHBRmDYwPJpHG33Y4t
Base automatically changed from claude/prd-gaps-remote-path-guards-3 to claude/prd-gaps-remote-path-guards October 1, 2026 07:19
@Ziinc
Ziinc merged commit b23cfec into claude/prd-gaps-remote-path-guards Oct 1, 2026
16 checks passed
@Ziinc
Ziinc deleted the claude/prd-gaps-remote-path-guards-4 branch October 1, 2026 07:19

Ziinc commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

Consolidated into #649 (remote repo identity and trust). Closing.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
preview — b23cfec9 Deployed Oct 1, 2026 by Ziinc via build #1605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants