Repository navigation
refactor: remove Mission Control and dead terminal code; key agent columns "agent-<id>" - #629
Merged
Merged
Conversation
Mission Control only opened on a two-finger touch swipe, which desktop trackpads do not send, so it was unreachable. This removes it along with code nothing used: - TerminalMissionControl, its helpers and tests, the useTwoFingerSwipe hook, its screenshot spec, and its docs sections. - The preview output, last-input time and idle helper that only Mission Control and the unused close-idle action read. Terminal summaries now track only whether each terminal is streaming. - WorkspaceEditSession and Terminal, which nothing imported, and the get_window_repo_path command only they called. - Unused pane handle methods (createAgentSession, focusTerminal, closeTerminal, closeIdleTerminals, closeAllTerminals), the never-passed agent argument of onCreateNewSession, and the unread workspaceBranchName option of getOrCreateSession.
Contributor
|
🚀 Web preview: https://preview-629.treq-9zy.pages.dev |
This was referenced Sep 29, 2026
…-control # Conflicts: # src/components/terminal/types.ts
Collaborator
Author
|
After merging
I don't think this PR caused it:
I haven't found or made a fix for it. I'm re-running the failed job once. If it fails again I'll treat it as a real failure and dig in. Generated by Claude Code |
…-<id>" (#636) Co-authored-by: Claude <noreply@anthropic.com>
…-control # Conflicts: # src/components/ShowWorkspace.tsx
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Mission Control and the dead code the sessions chaos QA found. It also includes #636, which was merged into this branch.
Mission Control
useTwoFingerSwipe). Desktop trackpads send wheel events, not touch events, so it could not be reached.TerminalMissionControland its test;terminal-mission-control/(group builder, diff-stats hook, preview formatter, and their tests);useTwoFingerSwipeand its test;terminal-mission-controlscreenshot spec;web/docs.useTerminalSessionSummarieskept a throttled preview of each terminal's output, plus timestamps, only for Mission Control. It now tracks onlyisStreaming, the one field the sidebar spinner and the idle-agent lookup read.TerminalSessionSummarydropspreviewOutput,lastUserInputAtandlastActivityAt.isTerminalSessionIdleandTERMINAL_IDLE_THRESHOLD_MSare gone.Other dead code
WorkspaceEditSession.tsxandTerminal.tsx: nothing imported them.get_window_repo_path: onlyWorkspaceEditSessioncalled it. Removed the TS wrapper, the Rust command and its registration. The setter stays, becauseagent_runtimereads the map.createAgentSession,focusTerminal,closeTerminal,closeIdleTerminals,closeAllTerminals.agentargument ofonCreateNewSession, which no caller passed.workspaceBranchNameoption ofgetOrCreateSession, which was never read.Agent column ids (from #636)
Agent terminal columns were keyed
claude-<sessionId>, although every supported agent runs in the same kind of column. They are nowagent-<sessionId>. The PTY id (session-<id>) is unchanged.agentTerminalId()andagentSessionIdOf()interminal/agentTerminalId.tsbuild and parse the id. They replace every hand-builtclaude-string.ClaudeSessionDataAgentSessionDataclaudeSessionsagentSessionshandleCloseClaudeSessionhandleCloseAgentSessionTerminalEntrytype"claude""agent"Tests
agentTerminalId.test.ts. Tests and specs select agent columns with[data-terminal-id^="agent-"].tsc, lint,cargo fmtandcargo clippyare clean.maintoo, because they look for a "New agent terminal" button that no longer exists:workspace-delete-closes-terminalstreq-send-review-commentsterminal-header-workspace-labelterminal-pane-inset-controls