Repository navigation
feat(sidebar): spin a gray indicator on clean workspaces with a working agent - #630
Merged
Merged
Conversation
…ng agent The sidebar indicator only showed for conflicted or changed workspaces, so a clean workspace with a running agent looked idle. It now shows a gray spinner, labelled "Agent working", while an agent in a clean workspace streams output. Changed and conflicted workspaces keep their yellow and red indicators, which spin as before.
Collaborator
Author
|
I don't think this PR caused it:
I haven't found or made a fix for it. I'm re-running the failed job once. If it fails again I'll treat it as a real failure and dig in. Generated by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean workspace with a running agent had no sidebar indicator, so it looked idle.
Change
getWorkspaceStatusIndicatornow returns a neutral spinner for a clean workspace whose agent is streaming output:{ color: "neutral", spin: true, label: "Agent working" }, drawn gray (text-muted-foreground);workspace-status-indicator-<id>.Behaviour otherwise:
Tests
src/lib/workspace-status-indicator.test.ts.test/integration/sidebar-agent-spinner.test.tsx, using the fake agent: a clean workspace shows no indicator; after Cmd+] it shows the "Agent working" spinner; the spinner goes away once the agent is idle. Without the change this test fails.workspace-agent-session-spinnerscreenshot spec has a new capture,04-clean-working. I checked it:feat/session-cleanshows the gray spinner, andfeat/no-session-cleanshows nothing.tscand lint are clean. Unit tests pass (800/800), andtest/integration/workspace/**passes (136/136).Generated by Claude Code