Skip to content

chore(deps): update dependency java to v25 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 1 commit into from
Closed

chore(deps): update dependency java to v25 #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tools]
erlang = "29.0.2"
elixir = "1.20.1"
java = "17.0.2"
java = "25.0.3+9.0.LTS"

@github-actions github-actions Bot Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Java toolchain bump lacks rationale and compatibility coverage

The Java version jumps from 17.0.2 to 25.0.3+9.0.LTS with no explanation in the diff and no matching updates to specs, docs, or CI. Because this repo uses mise for Android SDK tooling and depends on a compatible JDK, a major Java bump can silently break Android target builds and local setup. The diff should include a comment or commit message explaining the Java 25 requirement, and there should be matching ShellSpec or CI coverage that exercises the Android SDK setup and Java-dependent tooling on the new version.

🤖 Instructions for AI agents

You are an AI agent asked to address a code review finding. Treat this block as your prompt.

Finding: Java toolchain bump lacks rationale and compatibility coverage

Details:

The Java version jumps from 17.0.2 to 25.0.3+9.0.LTS with no explanation in the diff and no matching updates to specs, docs, or CI. Because this repo uses mise for Android SDK tooling and depends on a compatible JDK, a major Java bump can silently break Android target builds and local setup. The diff should include a comment or commit message explaining the Java 25 requirement, and there should be matching ShellSpec or CI coverage that exercises the Android SDK setup and Java-dependent tooling on the new version.

Location: mise.toml:4

How to fix:

  1. Open mise.toml:4 and read the surrounding code so you understand the context before changing anything.
  2. Fix the underlying issue described in Details above — do not silence the symptom (e.g. by suppressing a warning, catching and discarding an error, or deleting the test that surfaces it).
  3. Run the project's existing test and lint commands and confirm they pass before reporting the task as complete.
  4. Keep the change minimal and focused on this finding; surface any unrelated concerns separately rather than bundling them in.
  5. Once the fix is committed, if the gh CLI is available, mark this review thread as resolved so the human reviewer knows it's been addressed — use the GitHub GraphQL resolveReviewThread mutation via gh api graphql (look up the thread ID for this comment first).

— Blick · default review

android-sdk = "21.0"
kotlin = "2.4.0"
rust = "1.96.0"
Expand Down
Loading