chore(deps): update dependency java to v25 - #126
renovate[bot] wants to merge 1 commit into
Conversation
| erlang = "29.0.2" | ||
| elixir = "1.20.1" | ||
| java = "17.0.2" | ||
| java = "25.0.3+9.0.LTS" |
There was a problem hiding this comment.
Java toolchain bump lacks rationale and compatibility coverage
The Java version jumps from 17.0.2 to 25.0.3+9.0.LTS with no explanation in the diff and no matching updates to specs, docs, or CI. Because this repo uses mise for Android SDK tooling and depends on a compatible JDK, a major Java bump can silently break Android target builds and local setup. The diff should include a comment or commit message explaining the Java 25 requirement, and there should be matching ShellSpec or CI coverage that exercises the Android SDK setup and Java-dependent tooling on the new version.
🤖 Instructions for AI agents
You are an AI agent asked to address a code review finding. Treat this block as your prompt.
Finding: Java toolchain bump lacks rationale and compatibility coverage
Details:
The Java version jumps from 17.0.2 to 25.0.3+9.0.LTS with no explanation in the diff and no matching updates to specs, docs, or CI. Because this repo uses mise for Android SDK tooling and depends on a compatible JDK, a major Java bump can silently break Android target builds and local setup. The diff should include a comment or commit message explaining the Java 25 requirement, and there should be matching ShellSpec or CI coverage that exercises the Android SDK setup and Java-dependent tooling on the new version.
Location: mise.toml:4
How to fix:
- Open
mise.toml:4and read the surrounding code so you understand the context before changing anything. - Fix the underlying issue described in Details above — do not silence the symptom (e.g. by suppressing a warning, catching and discarding an error, or deleting the test that surfaces it).
- Run the project's existing test and lint commands and confirm they pass before reporting the task as complete.
- Keep the change minimal and focused on this finding; surface any unrelated concerns separately rather than bundling them in.
- Once the fix is committed, if the
ghCLI is available, mark this review thread as resolved so the human reviewer knows it's been addressed — use the GitHub GraphQLresolveReviewThreadmutation viagh api graphql(look up the thread ID for this comment first).
— Blick · default review
0a30525 to
9921b9b
Compare
|
Closing this one. Renovate is proposing a java version from a distribution-specific datasource (the +build suffix format), but the java pin in mise.toml resolves through mise's openjdk backend, which only publishes plain versions like 17.0.0-17.0.2 and 25.0.0-25.0.2. The proposed version has no metadata in that backend, so mise cannot install it and CI fails at tool setup. If we want to track newer java builds, the right move is to switch the pin to an explicit distribution (temurin, corretto, etc.) and configure Renovate accordingly, rather than take these auto-generated bumps. Closing as invalid for now. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
17.0.2→25.0.3+9.0.LTSWarning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.