Skip to content

chore(deps): update dependency java to v25 - #126

Closed
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/java-25.x
Closed

renovate[bot] wants to merge 1 commit into
mainfrom
renovate/java-25.x

Conversation

@renovate

@renovate renovate Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
java major 17.0.2 → 25.0.3+9.0.LTS

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Comment thread mise.toml
erlang = "29.0.2"
elixir = "1.20.1"
java = "17.0.2"
java = "25.0.3+9.0.LTS"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Java toolchain bump lacks rationale and compatibility coverage

The Java version jumps from 17.0.2 to 25.0.3+9.0.LTS with no explanation in the diff and no matching updates to specs, docs, or CI. Because this repo uses mise for Android SDK tooling and depends on a compatible JDK, a major Java bump can silently break Android target builds and local setup. The diff should include a comment or commit message explaining the Java 25 requirement, and there should be matching ShellSpec or CI coverage that exercises the Android SDK setup and Java-dependent tooling on the new version.

🤖 Instructions for AI agents

You are an AI agent asked to address a code review finding. Treat this block as your prompt.

Finding: Java toolchain bump lacks rationale and compatibility coverage

Details:

The Java version jumps from 17.0.2 to 25.0.3+9.0.LTS with no explanation in the diff and no matching updates to specs, docs, or CI. Because this repo uses mise for Android SDK tooling and depends on a compatible JDK, a major Java bump can silently break Android target builds and local setup. The diff should include a comment or commit message explaining the Java 25 requirement, and there should be matching ShellSpec or CI coverage that exercises the Android SDK setup and Java-dependent tooling on the new version.

Location: mise.toml:4

How to fix:

  1. Open mise.toml:4 and read the surrounding code so you understand the context before changing anything.
  2. Fix the underlying issue described in Details above — do not silence the symptom (e.g. by suppressing a warning, catching and discarding an error, or deleting the test that surfaces it).
  3. Run the project's existing test and lint commands and confirm they pass before reporting the task as complete.
  4. Keep the change minimal and focused on this finding; surface any unrelated concerns separately rather than bundling them in.
  5. Once the fix is committed, if the gh CLI is available, mark this review thread as resolved so the human reviewer knows it's been addressed — use the GitHub GraphQL resolveReviewThread mutation via gh api graphql (look up the thread ID for this comment first).

— Blick · default review

@renovate
renovate Bot force-pushed the renovate/java-25.x branch from 0a30525 to 9921b9b Compare July 12, 2026 19:08
@pepicrft

Copy link
Copy Markdown
Contributor

Closing this one. Renovate is proposing a java version from a distribution-specific datasource (the +build suffix format), but the java pin in mise.toml resolves through mise's openjdk backend, which only publishes plain versions like 17.0.0-17.0.2 and 25.0.0-25.0.2. The proposed version has no metadata in that backend, so mise cannot install it and CI fails at tool setup.

If we want to track newer java builds, the right move is to switch the pin to an explicit distribution (temurin, corretto, etc.) and configure Renovate accordingly, rather than take these auto-generated bumps. Closing as invalid for now.

@pepicrft pepicrft closed this Jul 14, 2026
@renovate

renovate Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 25.x releases. But if you manually upgrade to 25.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate
renovate Bot deleted the renovate/java-25.x branch July 14, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant