Add native Polish localization support by Yuxin-Qiao · Pull Request #1253 · steipete/CodexBar

Yuxin-Qiao · 2026-05-31T16:26:22Z

Summary

add Polish (pl) as a selectable app language
add pl.lproj/Localizable.strings for native Polish localization
add language_polish label across existing locales
improve Polish translations for key user-facing UI (General/Display/Advanced, quota warnings, status/debug text)

Testing

ran localization-focused swift test targets
in this environment, SwiftPM expanded into a large full build graph; final pass/fail summary was not captured

clawsweeper · 2026-05-31T16:27:21Z

Codex review: needs real behavior proof before merge. Reviewed June 11, 2026, 1:36 PM ET / 17:36 UTC.

Summary
Review failed before ClawSweeper could summarize the requested change.

Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path.

Review metrics: none identified.

Merge readiness
Overall: 🌊 off-meta tidepool
Proof: 🌊 off-meta tidepool
Patch quality: 🌊 off-meta tidepool
Result: rating does not apply to this item.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

[P1] No close action taken because the review did not complete.

Maintainer options:

Decide the mitigation before merge
Retry the Codex review after fixing the execution failure.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

[P1] Review did not complete, so no work-lane recommendation was made.

Review details

Best possible solution:

Retry the Codex review after fixing the execution failure.

Do we have a high-confidence way to reproduce the issue?

Unclear. The review failed before ClawSweeper could establish a reproduction path.

Is this the best way to solve the issue?

Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction.

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model internal, reasoning high; reviewed against 3c2d23d1739a.

Label changes

Label changes:

remove P2: Current review triage priority is none.
remove merge-risk: 🚨 compatibility: Current PR review selected no merge-risk labels.

Label justifications:

rating: 🌊 off-meta tidepool: Overall readiness is 🌊 off-meta tidepool; proof is 🌊 off-meta tidepool and patch quality is 🌊 off-meta tidepool.

Evidence reviewed

What I checked:

failure reason: retryable codex transport failure.
codex failure detail: Codex review failed for this PR with exit 1.
codex stderr: itle" = "Почніть із входу";\n "start_at_login_subtitle" = "Автоматично відкриває CodexBar під час запуску Mac.";\n "show_cost_summary" = "Показати підсумок витрат";".
codex stdout: No stdout captured.

Likely related people:

unknown: Codex failed before it could trace repository history. (role: review did not complete; confidence: low)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 545c87d4ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-31T16:29:44Z

+/* English localization for CodexBar (base/fallback) */
+
+" providers" = " providers";
+"(System)" = "(System)";
+"30d" = "30d";
+"A managed Codex login is already running. Wait for it to finish before adding " = "A managed Codex login is already running. Wait for it to finish before adding ";


Translate the Polish strings before enabling Polish

When users select the new Polish language, localizedBundle() will load this pl.lproj file, but the file is still mostly the English/base table (864 of 1029 entries match English, starting with the provider/login/account strings here). That makes the newly advertised Polish option render large parts of the app in English rather than Polish; translate these entries before shipping the language option.

Useful? React with 👍 / 👎.

Yuxin-Qiao · 2026-06-01T08:40:57Z

@clawsweeper re-review

Addressed in latest commits (c87caae, 891fd90), with additional Polish localization updates across key user-facing surfaces.

Proof (Polish selected in app)

1) Menu popup (core usage card + actions)

2) General settings pane

3) Providers pane

4) Display settings pane

5) Advanced settings pane

Notes

Polish is explicitly selected.
Updated many remaining menu/chart/action strings that previously fell back to English.
Hidden is still intentionally left as-is for now (tracked separately).

clawsweeper · 2026-06-01T08:40:59Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

State: Superseded
Detail: A newer re-review for this item started before this run finished, so GitHub cancelled this older run. Check the latest ClawSweeper run for the current result.
Run: https://github.com/openclaw/clawsweeper/actions/runs/26744436409
Updated: 2026-06-01T08:44:18.571Z

steipete · 2026-06-11T15:08:42Z

Rebased and updated the PR head to 618ebe62.

Completed:

rebased onto current main
restored exact English/Polish catalog key parity: 1038/1038 keys
translated five keys added or renamed since the original branch
added the unreleased changelog credit
focused localization/UI tests: 9 passed
make check: clean

Autoreview found one remaining merge blocker: 814 of 1038 Polish values are still exact English placeholders, leaving only 224 translated entries. Existing selectable non-English catalogs have roughly 990 or more translated values. This PR should stay open until the Polish catalog is substantially complete and native-quality; I am not auto-merging it in the current state.

- Add 'language_polish' to languageKeys in LocalizationLanguageCatalogTests so the new case in AppLanguage matches the test's expected key set. - Add 'language_polish' entry to fr/nl/uk/vi lproj (the four lproj added to main after the original Polish PR was opened) so the per-catalog coverage check passes. - Add missing language_french/dutch/ukrainian/vietnamese to pl.lproj with Polish translations so pl.lproj is also covered by the test.

…talogs) After rebasing onto origin/main, the invariant test 'localized catalogs include every app language label' requires every lproj to contain every language_<X> key. Add language_japanese to pl.lproj and language_polish to ja.lproj. No-op for app behavior; only catalog parity for invariant.

chatgpt-codex-connector Bot reviewed May 31, 2026

View reviewed changes

Yuxin-Qiao changed the title ~~Add native Polish app language support~~ Add native Polish localization support Jun 1, 2026

Yuxin-Qiao force-pushed the feat/polish-native-localization branch 2 times, most recently from 034add6 to d948204 Compare June 7, 2026 13:20

clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Jun 7, 2026

Yuxin-Qiao force-pushed the feat/polish-native-localization branch from f949d99 to 25ac8f2 Compare June 11, 2026 07:04

steipete force-pushed the feat/polish-native-localization branch from 25ac8f2 to 618ebe6 Compare June 11, 2026 15:08

Yuxin Qiao added 5 commits June 12, 2026 00:31

Add native Polish app language support

5665016

Improve Polish translations for core settings and menu UI

ce30f50

Polish quota/status and debug localization polish

08cf049

Polish: localize remaining providers screen and status labels

f9fa9e0

Polish: localize remaining menu and chart copy

7741529

Yuxin Qiao added 3 commits June 12, 2026 00:31

fix: complete Polish localization parity

86fa43c

Yuxin-Qiao force-pushed the feat/polish-native-localization branch from 618ebe6 to 86fa43c Compare June 11, 2026 16:31

chore: retrigger CI

bb31f02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add native Polish localization support#1253

Add native Polish localization support#1253
Yuxin-Qiao wants to merge 9 commits into
steipete:mainfrom
Yuxin-Qiao:feat/polish-native-localization

Yuxin-Qiao commented May 31, 2026

Uh oh!

clawsweeper Bot commented May 31, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 31, 2026

Uh oh!

Yuxin-Qiao commented Jun 1, 2026

Uh oh!

clawsweeper Bot commented Jun 1, 2026 •

edited

Loading

Uh oh!

steipete commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Yuxin-Qiao commented May 31, 2026

Summary

Testing

Uh oh!

clawsweeper Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

Yuxin-Qiao commented Jun 1, 2026

Proof (Polish selected in app)

1) Menu popup (core usage card + actions)

2) General settings pane

3) Providers pane

4) Display settings pane

5) Advanced settings pane

Notes

Uh oh!

clawsweeper Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clawsweeper Bot commented May 31, 2026 •

edited

Loading

clawsweeper Bot commented Jun 1, 2026 •

edited

Loading