Skip to content

Do not use -Werror when building rustc_llvm with GCC #160421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kobzol wants to merge 1 commit into from
Closed

Do not use -Werror when building rustc_llvm with GCC #160421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions compiler/rustc_llvm/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,11 @@ fn main() {
// for this platform. See https://github.com/rust-lang/rust/pull/145031#issuecomment-3162677202.
// Moreover, LLVM generally guarantees warning-freedom only when building with Clang, as other
// compilers have too many false positives. This is typically the case for MSVC, which throws
// many false-positive warnings. We keep it excluded, for these reasons.
if std::env::var_os("CI").is_some() && !target.contains("msvc") {
// many false-positive warnings, and also GCC. We keep these excluded, for these reasons.
let is_msvc = target.contains("msvc");
let compiler_is_gcc =
tracked_env_var_os("LLVM_COMPILER_IS_GNU_LIKE").as_deref() == Some(OsStr::new("1"));
if std::env::var_os("CI").is_some() && !is_msvc && !compiler_is_gcc {
cfg.warnings_into_errors(true);
}
for flag in &cxxflags {
Expand Down
3 changes: 3 additions & 0 deletions src/bootstrap/src/core/build_steps/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,9 @@ fn rustc_llvm_env(builder: &Builder<'_>, cargo: &mut Cargo, target: TargetSelect
if builder.config.llvm_assertions {
cargo.env("LLVM_ASSERTIONS", "1");
}
if builder.cxx_tool(target).is_like_gnu() || builder.cc_tool(target).is_like_gnu() {
cargo.env("LLVM_COMPILER_IS_GNU_LIKE", "1");
}
}

/// `RustcLink` copies compiler rlibs from a rustc build into a compiler sysroot.
Expand Down
Loading