Skip to content

Do not use -Werror when building rustc_llvm with GCC - #160421

Closed
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:rustc-llvm-no-werror
Closed

Do not use -Werror when building rustc_llvm with GCC#160421
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:rustc-llvm-no-werror

Conversation

@Kobzol

@Kobzol Kobzol commented Aug 3, 2026

Copy link
Copy Markdown
Member

Should hopefully unblock Illumos build failure for LLVM 23 upgrade (#158734 (comment)).

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2026
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@Kobzol Kobzol mentioned this pull request Aug 3, 2026
9 tasks
@cuviper

cuviper commented Aug 5, 2026

Copy link
Copy Markdown
Member

This commit was directly included in #158734.

@cuviper cuviper closed this Aug 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2026
@Kobzol
Kobzol deleted the rustc-llvm-no-werror branch August 5, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants