Repository navigation
Delete orphan RCTBridgeProxy shims (#59444) - #59444
Open
christophpurrer wants to merge 1 commit into
Open
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294703. |
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 24, 2026 03:22
ea3c714 to
2309ea4
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `bridgeDescription`, `moduleProvider`, `batchedBridge`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer`, `moduleSetupComplete`, `updateModuleWithInstance:`) and never-declared ones (`runtime`, `object`, write-only `jsCallInvoker`). Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 24, 2026 03:49
2309ea4 to
8a0570f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `bridgeDescription`, `moduleProvider`, `batchedBridge`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer`, `moduleSetupComplete`, `updateModuleWithInstance:`) and never-declared ones (`runtime`, `object`, write-only `jsCallInvoker`). Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Differential Revision: D127294703
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `bridgeDescription`, `moduleProvider`, `batchedBridge`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer`, `moduleSetupComplete`, `updateModuleWithInstance:`) and never-declared ones (`runtime`, `object`, write-only `jsCallInvoker`). Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 24, 2026 15:16
8a0570f to
105b2f6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `bridgeDescription`, `moduleProvider`, `batchedBridge`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer`, `moduleSetupComplete`, `updateModuleWithInstance:`) and never-declared ones (`runtime`, `object`, write-only `jsCallInvoker`). Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
2 times, most recently
from
October 27, 2026 14:18
105b2f6 to
64987ae
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `bridgeDescription`, `moduleProvider`, `batchedBridge`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer`, `moduleSetupComplete`, `updateModuleWithInstance:`) and never-declared ones (`runtime`, `object`, write-only `jsCallInvoker`). Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 27, 2026 14:38
64987ae to
afd00a6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Differential Revision: D127294703
Visual regression1 visual difference(s) at ios
|
| Expected | Captured |
|---|---|
 |
 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 28, 2026 15:21
afd00a6 to
6de8ab8
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 29, 2026 21:52
6de8ab8 to
8efa97d
Compare
meta-codesync
Bot
changed the title
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
Summary: Pull Request resolved: react#59444 Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 30, 2026 04:32
8efa97d to
73071d0
Compare
cipolleschi
approved these changes
Oct 30, 2026
andrewdacenko
approved these changes
Oct 30, 2026
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
Summary: Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 30, 2026 19:19
73071d0 to
74d6b18
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
Summary: Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 30, 2026 19:25
74d6b18 to
7d4fb92
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
Summary: Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 30, 2026 19:40
7d4fb92 to
3f1f22f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
Summary: Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 30, 2026 21:54
3f1f22f to
381a1ff
Compare
Summary: Remove orphan `RCTBridgeProxy` shims whose declarations are gone (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`, `object`). Keep `batchedBridge`, `bridgeDescription`, `runtime` (Expo/Reanimated call them) and `jsCallInvoker` (Skia fallback read; macOS fork keeps its reader). Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294703
christophpurrer
force-pushed
the
export-D127294703
branch
from
October 31, 2026 06:39
381a1ff to
c768fa1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove orphan
RCTBridgeProxyshims whose declarations are gone (parentBridge,moduleProvider,moduleSetupComplete,updateModuleWithInstance:, profiling,callNativeModule,logMessage,_immediatelyCallTimer:,object). KeepbatchedBridge,bridgeDescription,runtime(Expo/Reanimated call them) andjsCallInvoker(Skia fallback read; macOS fork keeps its reader).Changelog: [Internal]
Reviewed By: andrewdacenko
Differential Revision: D127294703