Delete orphan RCTBridgeProxy shims (#59444)

Summary:

Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `moduleProvider`, `moduleSetupComplete`, `updateModuleWithInstance:`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer:`) and never-declared ones (`object`, write-only `jsCallInvoker`). Keep `batchedBridge`, `bridgeDescription`, and `runtime`: Expo and Reanimated still call them. Shims backing deleted public API stay as runtime nets.

Changelog: [Internal]

Reviewed By: andrewdacenko

Differential Revision: D127294703

Author: christophpurrer

packages/react-native/React/Base/RCTBridge.h

@@ -21,16 +21,6 @@
 @class RCTBridge;
 @class RCTPerformanceLogger;
 
-/**
- * This block can be used to instantiate modules that require additional
- * init parameters, or additional configuration prior to being used.
- * The bridge will call this block to instantiate the modules, and will
- * be responsible for invalidating/releasing them when the bridge is destroyed.
- * For this reason, the block should always return new module instances, and
- * module instances should not be shared between bridges.
- */
-typedef NSArray<id<RCTBridgeModule>> * (^RCTBridgeModuleListProvider)(void);
-
 RCT_EXTERN_C_BEGIN
 
 /**

packages/react-native/React/Base/RCTBridgeProxy+Cxx.h

@@ -6,13 +6,11 @@
  */
 
 #import "RCTBridgeProxy.h"
-#import "RCTBridgeProxy+Cxx.h"
 
 #import <React/RCTBridge+Private.h>
 #import <React/RCTBridge.h>
 #import <React/RCTLog.h>
 #import <React/RCTUIManager.h>
-#import <ReactCommon/CallInvoker.h>
 #import <jsi/jsi.h>
 
 using namespace facebook;
@@ -24,12 +22,6 @@ - (NSMethodSignature *)methodSignatureForSelector:(SEL)sel;
 - (void)forwardInvocation:(NSInvocation *)invocation;
 @end
 
-@interface RCTBridgeProxy ()
-
-@property (nonatomic, readwrite) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-
-@end
-
 @implementation RCTBridgeProxy {
   RCTUIManagerProxy *_uiManagerProxy;
   RCTModuleRegistry *_moduleRegistry;
@@ -102,12 +94,6 @@ - (void *)runtime
   return _runtime;
 }
 
-- (std::shared_ptr<facebook::react::CallInvoker>)jsCallInvoker
-{
-  [self logWarning:@"Please migrate to RuntimeExecutor" cmd:_cmd];
-  return _jsCallInvoker;
-}
-
 /**
  * RCTModuleRegistry
  */
@@ -262,40 +248,11 @@ - (RCTBridge *)batchedBridge
   return (RCTBridge *)self;
 }
 
-- (void)setBatchedBridge
-{
-  [self logError:@"This method is not supported. No-oping." cmd:_cmd];
-}
-
-- (RCTBridgeModuleListProvider)moduleProvider
-{
-  [self logWarning:@"This method is not supported. Returning empty block" cmd:_cmd];
-  return ^{
-    return @[];
-  };
-}
-
 - (RCTModuleRegistry *)moduleRegistry
 {
   return _moduleRegistry;
 }
 
-/**
- * RCTBridge (RCTCxxBridge)
- */
-
-- (RCTBridge *)parentBridge
-{
-  [self logWarning:@"This method is not supported. Returning bridge proxy." cmd:_cmd];
-  return (RCTBridge *)self;
-}
-
-- (BOOL)moduleSetupComplete
-{
-  [self logWarning:@"This method is not supported. Returning YES." cmd:_cmd];
-  return YES;
-}
-
 - (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
 {
   [self
@@ -304,37 +261,6 @@ - (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
            cmd:_cmd];
 }
 
-- (void)updateModuleWithInstance:(id<RCTBridgeModule>)instance
-{
-  [self logError:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (void)startProfiling
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (void)stopProfiling:(void (^)(NSData *))callback
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (id)callNativeModule:(NSUInteger)moduleID method:(NSUInteger)methodID params:(NSArray *)params
-{
-  [self logError:@"This method is not supported. Nooping and returning nil." cmd:_cmd];
-  return nil;
-}
-
-- (void)logMessage:(NSString *)message level:(NSString *)level
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (void)_immediatelyCallTimer:(NSNumber *)timer
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
 /**
  * RCTBridge (Inspector)
  */
@@ -352,11 +278,6 @@ - (RCTUIManager *)uiManager
   return (RCTUIManager *)_uiManagerProxy;
 }
 
-- (RCTBridgeProxy *)object
-{
-  return self;
-}
-
 /**
  * NSProxy setup
  */

packages/react-native/React/Base/RCTBridgeProxy.mm

@@ -16,7 +16,6 @@
 #import <React/RCTBridge.h>
 #import <React/RCTBridgeModule.h>
 #import <React/RCTBridgeModuleDecorator.h>
-#import <React/RCTBridgeProxy+Cxx.h>
 #import <React/RCTBridgeProxy.h>
 #import <React/RCTComponentViewFactory.h>
 #import <React/RCTConstants.h>
@@ -324,7 +323,6 @@ - (void)_start
           }
           runtime:_reactInstance->getJavaScriptContext()
           launchOptions:_launchOptions];
-  bridgeProxy.jsCallInvoker = jsCallInvoker;
   bridgeProxy.performanceLogger = _performanceLogger;
   _bridgeProxy = bridgeProxy;
 

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm

@@ -51,10 +51,6 @@ category RCTBridge(RCTWebSocketModule) {
   public virtual RCTWebSocketModule* webSocketModule();
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -51,10 +51,6 @@ category RCTBridge(RCTWebSocketModule) {
   public virtual RCTWebSocketModule* webSocketModule();
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -51,10 +51,6 @@ category RCTBridge(RCTWebSocketModule) {
   public virtual RCTWebSocketModule* webSocketModule();
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -51,10 +51,6 @@ category RCTBridge(RCTWebSocketModule) {
   public virtual RCTWebSocketModule* webSocketModule();
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }