[pountzas]

Summary

• Move ~75 #[tauri::command] handlers from src-tauri/src/lib.rs into src-tauri/src/commands/<area>.rs (keyboard, mouse, window, profiles, files, teaching_pdf, library, dictation, system, prediction, input_preview).
• Move window layout/animation helpers to window/layout.rs; keep lib.rs as mods, AppState, run(), and generate_handler! (~171 lines).
• Shared pick_file replaces the four near-identical pickers; CommandResult / ok / err live in commands/mod.rs; typed TeachingPdfEntry for list/save (on-disk JSON unchanged). Command fn names and invoke strings unchanged.

Commit message

refactor: split lib.rs Tauri commands into commands modules

Related issue

Fixes #242
Part of #244

Accessibility impact

N/A — backend module split only; no user-facing behavior change.

Test plan

• cargo check --locked (src-tauri)
• cargo test --locked (152 passed)
• npm test (559 passed)
• Sorted generate_handler! cmd list matches pre-split baseline (68 commands)
• Smoke: typing, trackpad, Focus mode animation, profile switch, background/music/PDF pickers, Teaching PDF open/save/export, dictation

Screenshots (if UI changed)

N/A

Made with Cursor

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6f6a9a71-c00a-48ea-98db-c0039725430f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pountzas]

Review: refactor split of lib.rs (#242)

The split itself is clean. I compared every function, struct and const from the old lib.rs against its new home with whitespace and visibility normalized: all ~75 commands, CommandResult/ok/err, MusicFilePayload, ALLOWED_MS_SETTINGS_PAGES, RestoreAlwaysOnTop and the window-layout helpers are byte-for-byte moves apart from path prefixes (crate::, super::) and pub visibility. The sorted generate_handler! list is identical (75 entries incl. the 7 companion commands), parameter names are unchanged (so invoke args still match), run() only changed formatting, and teaching_pdf.rs (#291 validation) is untouched. pick_file keeps the same filters, parent, save-name and always-on-top restore; there were no dialog titles before, so none are lost.

Acceptance criteria: lib.rs size/contents ✅, module layout per table ✅, fn names + handler list ✅, single CommandResult ✅, shared pick_file ✅, typed TeachingPdfEntry ✅ (with one regression below), #291 moved unchanged ✅. Still open: CI check was in progress when reviewed (build-windows skipped), and the manual smoke list is unchecked.

Required changes (priority order)

1. src-tauri/src/commands/teaching_pdf.rs cmd_list_teaching_pdfs: don't fail the whole library when one stored entry doesn't match TeachingPdfEntry; skip invalid entries (and default title/lastOpenedAt) so loading stays as tolerant as before.
2. src-tauri/src/commands/teaching_pdf.rs: add unit tests that pin the on-disk camelCase JSON round-trip and the skip-invalid behavior.
3. Before merge: confirm CI check is green and run the Windows smoke list from the PR test plan (pickers, Teaching PDF open/save/export, Focus mode animation, dictation).

Optional: #242 asked for move-only commits first, then pick_file, then TeachingPdfEntry. This is one squashed commit. I verified the moves mechanically, so it isn't blocking.