Repository navigation
Conversation
Bumps the npm-minor-and-patch group with 2 updates: [@tauri-apps/api](https://github.com/tauri-apps/tauri) and [@tauri-apps/cli](https://github.com/tauri-apps/tauri). Updates `@tauri-apps/api` from 2.12.2 to 2.12.3 - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](https://github.com/tauri-apps/tauri/compare/@tauri-apps/api-v2.12.2...@tauri-apps/api-v2.12.3) Updates `@tauri-apps/cli` from 2.12.1 to 2.12.2 - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](https://github.com/tauri-apps/tauri/compare/@tauri-apps/cli-v2.12.1...@tauri-apps/cli-v2.12.2) --- updated-dependencies: - dependency-name: "@tauri-apps/api" dependency-version: 2.12.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-minor-and-patch - dependency-name: "@tauri-apps/cli" dependency-version: 2.12.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…with 5 updates Bumps the cargo-minor-and-patch group with 5 updates in the /src-tauri directory: | Package | From | To | | --- | --- | --- | | [tauri](https://github.com/tauri-apps/tauri) | `2.12.1` | `2.12.2` | | [serde_json](https://github.com/serde-rs/json) | `1.0.151` | `1.0.154` | | [uuid](https://github.com/uuid-rs/uuid) | `1.26.1` | `1.28.0` | | [tokio](https://github.com/tokio-rs/tokio) | `1.53.1` | `1.53.2` | | [tauri-build](https://github.com/tauri-apps/tauri) | `2.7.1` | `2.7.2` | Updates `tauri` from 2.12.1 to 2.12.2 - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](tauri-apps/tauri@tauri-v2.12.1...tauri-v2.12.2) Updates `serde_json` from 1.0.151 to 1.0.154 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.151...v1.0.154) Updates `uuid` from 1.26.1 to 1.28.0 - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@v1.26.1...v1.28.0) Updates `tokio` from 1.53.1 to 1.53.2 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.53.1...tokio-1.53.2) Updates `tauri-build` from 2.7.1 to 2.7.2 - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](tauri-apps/tauri@tauri-build-v2.7.1...tauri-build-v2.7.2) --- updated-dependencies: - dependency-name: serde_json dependency-version: 1.0.152 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch - dependency-name: tauri dependency-version: 2.12.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch - dependency-name: tauri-build dependency-version: 2.7.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch - dependency-name: tokio dependency-version: 1.53.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch - dependency-name: uuid dependency-version: 1.28.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Move IPC handlers out of the god-file so feature PRs stop conflicting, with shared pick_file and typed TeachingPdfEntry. Closes #242. Co-authored-by: Cursor <cursoragent@cursor.com>
Skip invalid stored entries and default missing title/lastOpenedAt so typed TeachingPdfEntry does not regress the old frontend filter. Co-authored-by: Cursor <cursoragent@cursor.com>
refactor: split lib.rs Tauri commands into commands modules
…-minor-and-patch-3b26397cd4 chore(deps): bump the npm-minor-and-patch group with 2 updates
Bumps the cargo-minor-and-patch group in /src-tauri with 4 updates: [tauri-plugin-opener](https://github.com/tauri-apps/plugins-workspace), [tauri-plugin-updater](https://github.com/tauri-apps/plugins-workspace), [tokio](https://github.com/tokio-rs/tokio) and [tauri-build](https://github.com/tauri-apps/tauri). Updates `tauri-plugin-opener` from 2.7.1 to 2.7.2 - [Release notes](https://github.com/tauri-apps/plugins-workspace/releases) - [Commits](tauri-apps/plugins-workspace@fs-v2.7.1...dialog-v2.7.2) Updates `tauri-plugin-updater` from 2.13.3 to 2.14.0 - [Release notes](https://github.com/tauri-apps/plugins-workspace/releases) - [Commits](tauri-apps/plugins-workspace@updater-v2.13.3...updater-v2.14.0) Updates `tokio` from 1.53.2 to 1.53.3 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.53.2...tokio-1.53.3) Updates `tauri-build` from 2.7.2 to 2.7.3 - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](tauri-apps/tauri@tauri-build-v2.7.2...tauri-build-v2.7.3) --- updated-dependencies: - dependency-name: tauri-plugin-opener dependency-version: 2.7.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch - dependency-name: tauri-plugin-updater dependency-version: 2.14.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-and-patch - dependency-name: tokio dependency-version: 1.53.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch - dependency-name: tauri-build dependency-version: 2.7.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Enable typed linting (strictTypeChecked + stylisticTypeChecked), React Hooks, React Refresh, and jsx-a11y strict so Agent and CI catch React/TS issues early. Wire npm run lint into the Build workflow and clean up existing violations. Co-authored-by: Cursor <cursoragent@cursor.com>
…cargo-minor-and-patch-428e95e853 chore(deps): bump the cargo-minor-and-patch group in /src-tauri with 4 updates
Exclude windowHeightRatio from pointer-kind layout swaps, harden mouse detection, strip stale 1.0 snapshots on load/save, ignore mirrored monitors for Normal full-work-area, and always release modifiers after SendInput failures. Co-authored-by: Cursor <cursoragent@cursor.com>
Ignore non-left/guarded mouse instead of treating as touch; repair persisted flat 1.0 when snapshots were stale; always release Shift in type_text and surface modifier key-up errors; log layout IPC on Focus and other paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the stray brace that broke tsc, and reinstate exhaustive StackableSectionId handling plus drop the ignored undoFrom option from review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
…o-full-screen fix: stop keyboard jumping to full screen on touch after mode switch
chore: add strict ESLint for React and TypeScript
Vite warned that the NPM package lagged the tauri-plugin-updater crate. Co-authored-by: Cursor <cursoragent@cursor.com>
chore: align plugin-updater npm with Rust 2.14.0
|
Important Review skippedToo many files! This PR contains 197 files, which is 97 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters: 2
📒 Files selected for processing: 197
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pountzas
commented
Oct 19, 2026
pountzas
left a comment
pountzas
left a comment
Owner
Author
There was a problem hiding this comment.
No code changes needed. This promotion is good to merge once the manual test plan is done.
What I checked on d260730:
- CI: the Build run (
checkandbuild-windows) passed. Typecheck, the newnpm run lintstep, vitest, Rustcargo testand the Windows bundle all went green. ESLint left 6 warnings: 3react-hooks/exhaustive-depsinuseFlipLayoutTransition.ts,NewLanguageListForm.tsxandSynthesizer.tsx, and 3jsx-a11y/no-static-element-interactionsinFocusModeShell.tsx,CollapsedFab.tsxandAppShell.tsx. All of them are in dependency arrays and handlers that already exist onmain, so they aren't regressions. - #307 / #299 follow-ups are all in:
pointerKindFromEventreturnsnullfor non-left, non-primary, unknown and guarded mouse events, andhandlePointerInputEventskips those.loadProfileDataruns the one-timerepairStaleFullscreenFlatHeightand persists the result.type_text_with_senderalways releases Shift, andrelease_modifiersreturns the first key-up error. Both have mock-sender tests.logLayoutIpcnow wraps everycmd_apply_window_layout/cmd_animate_window_layoutcall site (boot, Focus, live height, collapse/expand, settings patch). - #306 follow-ups are all in: the exhaustive
satisfies neverswitches are back inFloatingSection.handleCloseandSectionCanvas.isSectionVisibleId, and so is thedrag.id !== idguard. The menu and tablist containers usetabIndex={-1},windowMinMidiuses_octaveCount,CompanionSectionuses rest-destructure, the deadundoFromoption is removed, andmouseSpeeduses an own-property check. - #295 split: the
generate_handler!list is identical tomain(75 commands, none added or dropped). - #308 / deps: npm
@tauri-apps/plugin-updater2.14.0 matchestauri-plugin-updater2.14.0 inCargo.lock. The other Tauri packages are aligned on major.minor. - Release flow:
devis 0 commits behindmain, so the v0.17.0 release commits are already in. Versions stay at 0.17.0 because Release Please bumpspackage.json,tauri.conf.json,Cargo.tomlandCargo.lockafter merge. A merge commit (as with #235) keepsdevandmainhistory aligned.
Before merge (non-code):
- PR description: run and tick the manual test plan. That means touch after a Normal↔Focus switch staying at normal height on single, extended and mirrored monitors, plus the Settings / Teaching / Focus smoke test on Windows. CI can't cover the touch path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote current
devintomain(since #235 / v0.17.0). Includes:windowHeightRationo longer swapped with pointer-kind layouts)@tauri-apps/plugin-updaternpm with Rust crate 2.14.0lib.rsTauri commands intocommandsmodulesCommit message
fix: promote dev — touch fullscreen, ESLint, commands splitRelated issue
Closes #299 (via #307). Closes #305 (via #306).
Accessibility impact
Fixes a regression where touch after a Normal↔Focus switch could force near-fullscreen keyboard height — important for motor-disability / touch-first use.
Test plan
npm run typecheck/npm run lint/npm testnpm run tauri:dev— no updater package version mismatchScreenshots (if UI changed)
N/A — behavior and tooling; no intentional UI redesign.