Skip to content

test(connections): mock Slack validation before token revocation #15791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erichare merged 1 commit into from
Oct 15, 2026
Merged

test(connections): mock Slack validation before token revocation #15791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/backend/tests/unit/api/v1/test_connection_revocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import httpx
import pytest
from langflow.services.connection.oauth import providers
from langflow.services.database.models.connection import ConnectionSecret
from langflow.services.deps import session_scope

Expand All @@ -26,10 +25,15 @@
],
)
async def test_revoke_pasted_slack_token(
client, logged_in_headers, monkeypatch, token, identity, provider_response, expected
client, logged_in_headers, monkeypatch, respx_mock, token, identity, provider_response, expected
):
monkeypatch.setenv("LANGFLOW_CONNECTION_OAUTH_CONTEXT", "self_managed")
monkeypatch.setenv("LANGFLOW_CONNECTION_OAUTH_REGISTRATIONS", "{}")
# Web API tokens must pass validation before they can be stored and revoked.
if not token.startswith("xapp-"):
respx_mock.post("https://slack.com/api/auth.test", headers={"Authorization": f"Bearer {token}"}).respond(
200, json={"ok": True}
)
created = await client.post(
"/api/v1/connections",
headers=logged_in_headers,
Expand All @@ -43,10 +47,8 @@ async def test_revoke_pasted_slack_token(
)
assert created.status_code == 201, created.text
connection_id = created.json()["id"]
calls = []

def slack(request):
calls.append(request)
assert request.method == "POST"
assert str(request.url) == "https://slack.com/api/auth.revoke"
assert request.headers["Authorization"] == f"Bearer {token}"
Expand All @@ -56,23 +58,18 @@ def slack(request):
raise httpx.ReadTimeout(msg, request=request)
return httpx.Response(200, json=provider_response)

original_client = httpx.AsyncClient
monkeypatch.setattr(
providers.httpx,
"AsyncClient",
lambda **kwargs: original_client(transport=httpx.MockTransport(slack), **kwargs),
)
revoke_request = respx_mock.post("https://slack.com/api/auth.revoke").mock(side_effect=slack)
revoked = await client.post(f"/api/v1/connections/{connection_id}/revoke", headers=logged_in_headers)
assert revoked.status_code == 200, revoked.text
assert revoked.json()["provider_revocation"] == expected
assert revoked.json()["status"] == "revoked"
assert revoked.json()["has_credentials"] is False
assert token not in revoked.text
assert len(calls) == 1
assert revoke_request.call_count == 1
async with session_scope() as session:
assert await session.get(ConnectionSecret, UUID(connection_id)) is None

repeated = await client.post(f"/api/v1/connections/{connection_id}/revoke", headers=logged_in_headers)
assert repeated.status_code == 200, repeated.text
assert repeated.json()["provider_revocation"] == "not_applicable"
assert len(calls) == 1
assert revoke_request.call_count == 1
Loading