Skip to content

test(connections): mock Slack validation before token revocation - #15791

Merged
erichare merged 1 commit into
release-1.13.0from
fix/slack-revocation-test-validation
Oct 15, 2026
Merged

erichare merged 1 commit into
release-1.13.0from
fix/slack-revocation-test-validation

Conversation

@erichare

Copy link
Copy Markdown
Member

After #15766 and #15767 merged, eight revocation cases failed while creating their connection because the fake Slack token reached the new auth.test validation call.

Mock successful validation before creating bot/user connections and use the existing RESPX fixture for revocation as well. App-level tokens still skip Web API validation. The tests retain all nine revocation cases, credential deletion, and repeated-revocation assertions. Production behavior is unchanged.

Validation:

  • Reproduced 8 failures and 1 pass on 2d6c38d595 before the fix.
  • 145 passed on Python 3.14: revocation and identity API tests plus the complete connection service test directory.
  • Ruff format/check and git diff --check passed.

Addresses the reported regression.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: langflow-ai/langflow/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4cdab65b-4d2b-4664-800b-7f2ec1283194
📥 Commits

Reviewing files that changed from the base of the PR and between 2d6c38d and edc2f18.

📒 Files selected for processing: 1
  • src/backend/tests/unit/api/v1/test_connection_revocation.py
+-------------------------------------------------------------+
| Return early? Yes. Return *something meaningful*? Also yes. |
+-------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erichare
erichare marked this pull request as ready for review October 15, 2026 20:28
@erichare
erichare merged commit bd14570 into release-1.13.0 Oct 15, 2026
34 checks passed
@erichare
erichare deleted the fix/slack-revocation-test-validation branch October 15, 2026 20:28
@github-actions github-actions Bot added the test Changes to tests label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Advisor

No source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉

Advisory check only — never blocks merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Changes to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant