Cache generated JSON schemas by Class and Type - #1
Open
skrcode wants to merge 2 commits into
Open
Conversation
The shared static victools SchemaGenerator is not thread-safe: its JacksonModule keeps an unsynchronized introspection cache, so concurrent structured calls can fail with ConcurrentModificationException. Guard both schemaGenerator.generateSchema(...) call sites with a dedicated lock.
…emaUtils lock contention
Open
5 tasks
jnduan
force-pushed
the
fix/jsonschema-thread-safety
branch
2 times, most recently
from
August 27, 2026 16:26
16a0623 to
7cc7317
Compare
jnduan
force-pushed
the
fix/jsonschema-thread-safety
branch
5 times, most recently
from
September 3, 2026 01:32
186f878 to
35080eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a one-commit JAIPilot Cloud follow-up on the exact current head of agentscope-ai/agentscope-java#2796. It targets the original contributor branch so there is no duplicate upstream feature PR.
Change
Cache each generated JsonNode by Class or Type. Cache misses still use the existing SCHEMA_LOCK, while every caller still receives a newly converted, independently mutable Map.
Proof
Boundary and disclosure
The benefit depends on repeated schema types. The caches retain one entry per encountered Class or Type, so the project should confirm that lifecycle assumption for dynamic class-loading environments. Absolute production latency is not claimed.
JAIPilot Cloud generated and validated the patch in skrcode/agentscope-java#2. I reviewed the exact ancestry, complete two-file diff, test evidence, measurement boundary, and limitation before offering it here.