refactor(routes): rely on RuntimeRoutesProvider for URL generation#95
Merged
Merged
Conversation
Merge all responsive rules into screen.css under .horde-responsive scope. Delete standalone responsive.css. Fix icon overlay bug by lowering fallback specificity so inline icon CSS from ResponsiveTopbar takes precedence.
Move all responsive template references from responsive.css to screen.css. Fix icon overlay bug by lowering fallback specificity so inline icon CSS from ResponsiveTopbar takes precedence.
- Add horde-responsive class to legacy login.php body tag
- Add #[Factory] attributes to LoginService and RedirectValidationService
so the injector can resolve their array $conf parameter
- Replace $request->getAttribute('registry') with RegistryConfigLoader
in ResponsiveLoginController (attribute not set under Rampage)
- Catch Throwable in Login::secondFactorApi() for guest user access
- Catch Throwable in LoginService language change (PHP 8.4 ValueError)
- Add turba, trean, tessera, satisfiend to icon generation script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue horde/Core#121
Requires horde/Core#122
No longer need an app-level UriBuilder.