refactor(routes): rely on RuntimeRoutesProvider for URL generation#122
Merged
Conversation
…er to AssetCollector Add inline CSS support to AssetCollector (addInlineStyle, renderInlineStyleBlock) and wire it into PageComposer head output. Create PageOutputAssetManager adapter implementing Form's AssetManager interface. When injected into HtmlRenderer, form-required assets flow into Core's page-level AssetCollector instead of rendering inline. render() returns empty string since PageComposer handles placement. Add horde/form to composer.json require (Core implements Form's interface, not the other way around).
Member
Author
|
Added integration between horde/form css / js assets and horde/core modern PageOuput. |
…een.css ResponsiveChromeRenderer and traits now request screen.css instead of responsive.css. Per-app responsive rules live in each app's screen.css under .horde-responsive scope, discovered via CascadeCssDiscoverer.
The topbar factory was passing the raw app identifier (e.g. 'turba') as the display name. Now resolves the translated name from RegistryState via RegistryConfigLoader, showing proper localized names like "Address Book" or "Adressbuch".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #121
Rename RuntimeRoutesMapper to RuntimeRoutesProvider and amend so that it can also render/produce routes.
Base feature for this set:
Merge after testing together with horde/base#95 or wait until monday.