Skip to content

chore: strengthen coding standards enforcement - #549

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/mcp-server-coding-standards-b7d6
Closed

chore: strengthen coding standards enforcement#549
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/mcp-server-coding-standards-b7d6

Conversation

@cursor

@cursor cursor Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

Audits and hardens automated enforcement of the registry-driven MCP architecture documented in docs/coding-standards.md.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (CI/guardrails)

What changed

  1. tests/coding-standards/allowed-tools.ts — single source of truth for the 11 consolidated MCP tools, handler allowlists, fetch/client.request exceptions, and toolset helper files.
  2. tests/coding-standards/docs-consistency.test.ts — verifies docs/coding-standards.md, CONTRIBUTING.md, PR template, package.json, and CI workflows stay aligned with the enforced tool surface (11 tools, Zod v4, pnpm standards:check).
  3. Refactored existing standards tests to import shared allowlists instead of duplicating constants across files.
  4. Schema sync workflows (sync-schemas.yml, sync-entity-schemas.yml) now install deps and run pnpm standards:check before opening automated PRs.

PR #532 review (trigger context)

Reviewed the pipeline input-set override fix in #532 against the architecture rules:

  • No new server.registerTool() calls — changes are in harness-execute.ts (allowed handler) and src/utils/runtime-input-resolver.ts (utility layer)
  • HTTP goes through injected HarnessClient — no raw fetch()
  • Uses createLogger (stderr) — no console.log()
  • Write path uses existing confirmViaElicitation gate
  • pnpm standards:check passes on that branch

Checklist

  • pnpm test passes (117 files / 2478 tests)
  • pnpm standards:check passes (10 files / 82 tests)
  • No new MCP tool handlers
  • No console.log() in src/
Open in Web View Automation 

- Add shared allowed-tools.ts as single source of truth for the 11 MCP tools
- Add docs-consistency.test.ts to keep docs/workflows aligned with guardrails
- Refactor standards tests to import shared allowlists instead of duplicating
- Run pnpm standards:check in schema sync workflows before opening PRs

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thisrohangupta

Copy link
Copy Markdown
Collaborator

Closing: duplicate 'strengthen coding standards guardrails' draft. Superseded by merged #536/#510 on main; the open variants (#505/#519/#522/#526/#541/#542/#549/#550) are near-identical to each other.

Triaged as part of an open-PR cleanup pass. If this was mis-triaged, reopen and rebase onto current main.

@thisrohangupta
thisrohangupta deleted the cursor/mcp-server-coding-standards-b7d6 branch July 22, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants