chore: strengthen coding standards enforcement - #549
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
- Add shared allowed-tools.ts as single source of truth for the 11 MCP tools - Add docs-consistency.test.ts to keep docs/workflows aligned with guardrails - Refactor standards tests to import shared allowlists instead of duplicating - Run pnpm standards:check in schema sync workflows before opening PRs Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This was referenced Jul 5, 2026
Collaborator
|
Closing: duplicate 'strengthen coding standards guardrails' draft. Superseded by merged #536/#510 on Triaged as part of an open-PR cleanup pass. If this was mis-triaged, reopen and rebase onto current |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audits and hardens automated enforcement of the registry-driven MCP architecture documented in
docs/coding-standards.md.Type of Change
What changed
tests/coding-standards/allowed-tools.ts— single source of truth for the 11 consolidated MCP tools, handler allowlists, fetch/client.request exceptions, and toolset helper files.tests/coding-standards/docs-consistency.test.ts— verifiesdocs/coding-standards.md,CONTRIBUTING.md, PR template,package.json, and CI workflows stay aligned with the enforced tool surface (11 tools, Zod v4,pnpm standards:check).sync-schemas.yml,sync-entity-schemas.yml) now install deps and runpnpm standards:checkbefore opening automated PRs.PR #532 review (trigger context)
Reviewed the pipeline input-set override fix in #532 against the architecture rules:
server.registerTool()calls — changes are inharness-execute.ts(allowed handler) andsrc/utils/runtime-input-resolver.ts(utility layer)HarnessClient— no rawfetch()createLogger(stderr) — noconsole.log()confirmViaElicitationgatepnpm standards:checkpasses on that branchChecklist
pnpm testpasses (117 files / 2478 tests)pnpm standards:checkpasses (10 files / 82 tests)console.log()insrc/