test: enforce coding standards guardrails for pure-data toolsets

[cursor]

Summary

Reviewed the codebase against docs/coding-standards.md registry-driven architecture rules. The project already enforces most standards via pnpm standards:check (72 automated tests in CI).

This PR closes one remaining gap: scs.ts imported createLogger, which violates the pure-data toolset rule.

Changes

• Fix scs.ts: Remove createLogger from remediation PR preflight; transient list failures now fail open silently (documented best-effort policy unchanged)
• Strengthen architecture.test.ts: Block utils/logger imports and createLogger() calls in toolset files
• Update docs/coding-standards.md: Document that toolsets must not import createLogger or use any logging

Verification

• pnpm standards:check — 72 tests pass
• pnpm test — 2453 tests pass

Standards coverage (already enforced)

Rule	Enforcement
11 fixed MCP tools only	architecture.test.ts
Pure-data toolsets	import bans + ToolsetDefinition export check
No console.log in src/	static scan
Singleton HarnessClient	instantiation check
Scope injection model	toolset-scope.test.ts, scope-params.test.ts
operationPolicy on endpoints	registry-contract.test.ts
Write confirmation / elicitation	registry-metadata.test.ts
Zod v4 + .describe() chaining	architecture.test.ts, input-conventions.test.ts
File organization	file-organization.test.ts

  

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thisrohangupta
❌ cursoragent
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[thisrohangupta]

Closing: duplicate 'strengthen coding standards guardrails' draft. Superseded by merged #536/#510 on main; the open variants (#505/#519/#522/#526/#541/#542/#549/#550) are near-identical to each other.

Triaged as part of an open-PR cleanup pass. If this was mis-triaged, reopen and rebase onto current main.