Skip to content

Guest agent: correct the idle-reclaim failure comment (#75 review P3) #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerryfane merged 1 commit into from
Oct 22, 2026
Merged

Guest agent: correct the idle-reclaim failure comment (#75 review P3) #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/sandboxd-guest-agent/reclaim_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ import (
// it writes back dirty pages, drops the page cache and reclaimable slab, and
// compacts memory: the dropped pages become free, and compaction gathers
// free pages into the 2 MiB blocks that free page reporting hands back to
// the host. It never stops the guest: a failure is logged and retried at the
// next quiet period.
// the host. It never stops the guest: a failed drop or compaction is logged
// and tried again at the next quiet period, and if /proc/stat cannot be read
// the reclaim logs that and ends for the life of the VM (the balloon still
// returns what the guest frees by itself).
func idleReclaim() {
var policy guestagent.IdleReclaim
last, err := cpuBusy()
Expand Down
Loading