Skip to content

feat!: move knex-specific database adapter errors into entity-database-adapter-knex - #715

Merged
wschurman merged 1 commit into
mainfrom
10-05-feat_move_knex-specific_database_adapter_errors_into_entity-database-adapter-knex
Oct 5, 2026
Merged

wschurman merged 1 commit into
mainfrom
10-05-feat_move_knex-specific_database_adapter_errors_into_entity-database-adapter-knex

Conversation

@wschurman

@wschurman wschurman commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Why

While reviewing #714, noticed that it was probably better if these knex/postgres-specific errors live in their package rather than the root package.

This is a breaking change but one that is detectable via tsc so within the scope of what's allowed via minor version bump.

How

Have claude move them. Prompt:

move knex-specific entity errors into the entity-database-adapter-knex package. no need for backwards
compatibility

Test Plan

CI

wschurman commented Oct 5, 2026 •

Copy link
Copy Markdown
Member Author

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c22ed50) to head (f14dfbf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #715   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       110    +1     
  Lines        18485     18499   +14     
  Branches      1596      1597    +1     
=========================================
+ Hits         18485     18499   +14     
Flag Coverage Δ
integration 30.66% <79.33%> (+0.59%) ⬆️
unittest 94.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wschurman commented Oct 5, 2026 •

Copy link
Copy Markdown
Member Author

Merge activity

  • Oct 5, 5:05 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 5, 5:05 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman
wschurman merged commit 6de0405 into main Oct 5, 2026
7 checks passed
@wschurman
wschurman deleted the 10-05-feat_move_knex-specific_database_adapter_errors_into_entity-database-adapter-knex branch October 5, 2026 17:05
wschurman added a commit that referenced this pull request Oct 5, 2026
# Why

Re-implementation of #714 on top of #715.

# How

Prompt:

> add new error for pg code 55P03, use PR 714 as reference but a new error class

# Test Plan

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants