Repository navigation
feat!: move knex-specific database adapter errors into entity-database-adapter-knex - #715
Merged
wschurman merged 1 commit intoOct 5, 2026
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 110 +1
Lines 18485 18499 +14
Branches 1596 1597 +1
=========================================
+ Hits 18485 18499 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wschurman
marked this pull request as ready for review
October 5, 2026 16:03
This was referenced Oct 5, 2026
sjchmiela
approved these changes
Oct 5, 2026
Member
Author
Merge activity
|
wschurman
deleted the
10-05-feat_move_knex-specific_database_adapter_errors_into_entity-database-adapter-knex
branch
October 5, 2026 17:05
wschurman
added a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
While reviewing #714, noticed that it was probably better if these knex/postgres-specific errors live in their package rather than the root package.
This is a breaking change but one that is detectable via tsc so within the scope of what's allowed via minor version bump.
How
Have claude move them. Prompt:
Test Plan
CI