Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 109 109
Lines 18485 18487 +2
Branches 1596 969 -627
==========================================
+ Hits 18485 18487 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sjchmiela
marked this pull request as ready for review
October 5, 2026 15:50
This was referenced Oct 5, 2026
wschurman
added a commit
that referenced
this pull request
Oct 5, 2026
…e-adapter-knex (#715) # Why While reviewing #714, noticed that it was probably better if these knex/postgres-specific errors live in their package rather than the root package. This is a breaking change but one that is detectable via tsc so within the scope of what's allowed via minor version bump. # How Have claude move them. Prompt: > move knex-specific entity errors into the entity-database-adapter-knex package. no need for backwards compatibility # Test Plan CI
wschurman
added a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
"Lock not available" is a rather transient error. Let's classify it as one!
How
Added mapping for
55P03error code (docs link is to bytebase.com, but, well, trust me that it is the right mapping).Test Plan
Added simple test.