pointers: scope define variables to their in - #317
Merged
Merged
Conversation
gnidan
force-pushed
the
pointers-define-scope
branch
from
October 3, 2026 18:57
4c71e00 to
3901b8c
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dereferencekept the variables of adefineafter itsinfinished. They were saved into one map that every later pointer shared, so adefineinside one member of agroupchanged the variables seen by the members after it. For example, in a group whose first member definesslotasslot + 1, a later member that readsslotsaw the shifted value instead of the outer one.This is where it showed up: solc's template for a struct with a string member (the
Orderstruct in the Shop example, from solc #16990) definesslot = slot + 1inside the string member, so every member after it was decoded one slot too far.The fix restores the variable map to its state before the
defineonce theinpointer is processed. The schema does not spell out the scoping rule, but variables exist only to build theinpointer, and nothing in the spec says they outlive it. Regions saved by name are not affected, so references such as{ ".offset": "array-count" }still work across group members.The tests cover the minimal group case and a
defineinside a template referenced from a group member. Includes a changelog entry.