format: say that a scope's variables are visible only within its in - #318
Merged
Merged
Conversation
gnidan
force-pushed
the
format-scope-visibility
branch
from
October 3, 2026 19:12
7ccd623 to
f3a60ee
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scope collection's description says its
inpointer is "defined with the aid of" the variables indefine, but it never says whether those variables stay visible afterwards. This states it: a scope's variables are visible only within itsin. Pointers outside the scope, such as later members of an enclosing group, see only the variables of their own enclosing scopes, and a variable that reuses an outer identifier shadows it only withinin.This is the reading solc's storage templates already depend on (argotorg/solidity#16990): a struct template whose string member defines
slotfor its own use expects the members after it to see the struct'sslot.@ethdebug/pointerslet those variables leak until #317.The schema description and the collections docs page say it, and the changelog records the impact: no change for producers, and consumers that keep a scope's variables after its
inmust discard them there.