Skip to content

Add version in gtag event #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HadrienGardeur merged 1 commit into from
Sep 1, 2026
Merged

Add version in gtag event #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/shared-content/DownloadContent.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import MsStoreBadge from "../buttons/MsStoreBadge.astro";
import ActionButton from "../buttons/ActionButton.astro";
import ClientData from "../ClientData.astro";
import { t, getImage, slugify, splitLinks, type LinkSlot } from "../../i18n/utils.js";
import { downloadUrls, downloadPlatforms } from "../../links.js";
import { downloadUrls, downloadPlatforms, desktopVersion } from "../../links.js";
import { BREAKPOINT_MOBILE } from "../../breakpoints.js";
import { getRelativeLocaleUrl } from "astro:i18n";
import rawShape6WaveBottom from "../../assets/shapes/thorium-shape-6-wave-bottom.svg?raw";
Expand All @@ -22,10 +22,10 @@ const { lang } = Astro.props;

const downloadLinks = t(lang, "download.tabs.links", { returnObjects: true }) as Record<string, string>;

const downloadLinkSlots: Record<string, LinkSlot & { platform: string }> = Object.fromEntries(
const downloadLinkSlots: Record<string, LinkSlot & { platform: string; version: string }> = Object.fromEntries(
Object.entries(downloadUrls).map(([ key, url ]) => [
key,
{ href: url, text: downloadLinks[key] ?? key, platform: downloadPlatforms[key] ?? "" },
{ href: url, text: downloadLinks[key] ?? key, platform: downloadPlatforms[key] ?? "", version: desktopVersion },
])
);

Expand Down Expand Up @@ -74,7 +74,7 @@ const osTabs = Object.entries(tabsData)
{ osSteps(tab.key).map(step => (
<li>
{ splitLinks(step, downloadLinkSlots).map(seg =>
typeof seg === "string" ? seg : <a href={ seg.href } data-platform={ seg.platform }>{ seg.text }</a>
typeof seg === "string" ? seg : <a href={ seg.href } data-platform={ seg.platform } data-version={ seg.version }>{ seg.text }</a>
) }
</li>
)) }
Expand Down Expand Up @@ -186,6 +186,7 @@ const osTabs = Object.entries(tabsData)
link_text: link.textContent?.trim(),
file_name: downloadLabel(link.href),
platform: link.dataset.platform || undefined,
version: link.dataset.version || undefined,
});
});
</script>