Repository navigation
Add version in gtag event - #63
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR augments download link analytics by attaching the current desktop app version to each rendered download link and including that version in the gtag("event", "thorium_download", ...) payload, improving the ability to segment download events by release.
Changes:
- Import
desktopVersionand attach it asdata-versionon rendered download links. - Extend
downloadLinkSlotsto carry aversionvalue alongsideplatform. - Include
versionin thethorium_downloadgtag event parameters.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title is self-describing.