Skip to content

feat(settings): raise terminal font size max to 64px with stepped slider and px input#511

Merged
danshapiro merged 1 commit into
mainfrom
feat/font-size-400
Jul 8, 2026
Merged

feat(settings): raise terminal font size max to 64px with stepped slider and px input#511
danshapiro merged 1 commit into
mainfrom
feat/font-size-400

Conversation

@danshapiro

Copy link
Copy Markdown
Owner

What

Raise the terminal font size cap from 32px to 64px (400% of the 16px base, matching the UI scale treatment) and move the Font size row to SteppedRangeInput:

  • Discrete slider over TERMINAL_FONT_SIZE_PX_OPTIONS: 1px steps from 12-32, 2px steps 34-48, 4px steps 52-64 (33 stops)
  • Numeric px input alongside; commits on blur/Enter, Escape reverts, clamps to [12, 64], typed off-list values (e.g. 33) are legal
  • New optional annotation prop on SteppedRangeInput surfaces the percent-of-base annotation ("16px (100%)") in aria-valuetext and a live suffix label; no behavior change for callers without it
  • docs/index.html mock rows updated (font size max 64; stale UI scale max from feat(settings): raise UI scale max to 400% with stepped slider and percent input #509 fixed to 4)

Why

Parity with the UI scale 400% change (PR #509) for low-vision and large-display use — the terminal font size setting was still capped at 32px.

Verification

  • npm run check full coordinated suite green (typecheck + 8,694 tests passed)
  • npm run lint 0 errors
  • TDD per repo convention; full test coverage incl. keyboard boundary at 32px
  • Spec doc included at docs/plans/2026-07-08-terminal-font-size-400-spec.md
  • Note: the e2e-browser spec was updated for the new control, but Playwright was not run (outside the coordinated suite)

Generated with Amplifier

…der and px input

The terminal font size setting previously capped at 32px. Raise
TERMINAL_FONT_SIZE_MAX to 64 (400% of the 16px base, matching the UI
scale treatment) and move the Font size row to SteppedRangeInput:

- Discrete slider over TERMINAL_FONT_SIZE_PX_OPTIONS: 1px steps from
  12-32, 2px steps 34-48, 4px steps 52-64 (33 stops)
- Numeric px input alongside; commits on blur/Enter, Escape reverts,
  clamps to [12, 64], typed off-list values (e.g. 33) are legal
- New optional annotation prop on SteppedRangeInput surfaces the
  percent-of-base annotation ("16px (100%)") in aria-valuetext and a
  live suffix label; no behavior change for callers without it
- docs/index.html mock rows updated (font size max 64; stale UI scale
  max from #509 fixed to 4)
- Full test coverage incl. keyboard boundary at 32px; verified with
  npm run check (full coordinated suite green)

Generated with Amplifier

Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
@danshapiro danshapiro merged commit b5daeea into main Jul 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant