feat(editor): editor pane font size follows terminal font size setting#513
Merged
Conversation
The Monaco editor pane hard-coded fontSize: 14, ignoring the Font size setting that already drives the terminal, the fresh-agent transcript, and (via --ui-scale) the whole UI. Subscribe to settings.terminal.fontSize (direct 1:1 mapping, default 16) in the Monaco options literal; live updates ride @monaco-editor/react's built-in options -> updateOptions effect, so open editors resize without remounting. New EditorPane.fontSize tests cover default, mount-after-change, live-update without remount, and clamped values. Verified with npm run check (full coordinated suite green). Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace Monaco's hard-coded
fontSize: 14inEditorPane.tsxwith a subscription tosettings.terminal.fontSize(direct 1:1, default 16); live updates ride @monaco-editor/react's built-in options→updateOptions effect (open editors resize without remount, 2-line source change). NewEditorPane.fontSize.test.tsxcovers default, mount-after-change, live-update-without-remount, clamp. Spec doc included atdocs/plans/2026-07-08-editor-font-follows-setting-spec.md.Why
The Font size setting already drives the terminal, fresh-agent transcript, and global UI scale; the editor pane was the one holdout (follow-up to #511).
Verification
npm run checkfull coordinated suite green (8,698 tests)Generated with Amplifier