Repository navigation
A per-output path ending in / is a folder - #70
Merged
Merged
Conversation
added 3 commits
October 17, 2026 17:55
The output is written into it under its own name: --output-table /data/run1/ writes /data/run1/table.qza. The same rule applies to publish destinations and to output paths in a pipeline file's config or an arguments file. Only the text decides, never the disk, so a shared pipeline means the same thing on every machine.
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A per-output destination ending in
/now names a folder, and the output is written into it under its own name:--output-table /results/run-001/writes/results/run-001/table.qza(.qzvfor a visualization). Without the trailing/the path is the file itself, as before.--output-*flags,outputsin an arguments file or a pipeline file's bundled config, andpublishdestinations sent by Desktop / Runtime Server runs (all go throughresolve_output_destination).--output-*help text states the rule.This matches the rule the editor now uses (cymis/adagio-app#462). The app sends complete file paths, so this is for hand-written arguments and flags, and for consistency.
Tests: new
tests/test_output_folders.py; full suite 275 passed; ruff clean. Verified by running a downloaded.adgwith--output-denoising-stats <dir>/, which wrote<dir>/denoising_stats.qza.Update: wording only, "folder" → "directory" to match the editor (
is_directory_path, help text). No behavior change was needed for Directory variables in input paths: the app sends complete paths.