Repository navigation
Conversation
Lancetnik
added this pull request to stack #131
October 6, 2026 16:22
Branch coverage
42 files skipped due to complete coverage. |
This was referenced Oct 6, 2026
Lancetnik
marked this pull request as ready for review
October 10, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Installed Card definitions can now be managed from Files and Settings. Profile and Global
.card.yamlfiles use the existing editor and ETag/If-Match save flow; Bundled files are viewable through a read-only mount.This PR is the top layer of the explicit
gh stack: #129 → #130 → this PR. Its base isfeat/card-authorat4d236f4; the review diff contains Issue #87's Cards management work.Related issue number
Closes #87.
Checks
ruff check .,ruff format --check ., andpytest -m "not integration"locally and they pass.web/, I rebuilt and committed the SPA bundle (npm --prefix web run build).Full Python 3.13 unit suite: 2369 passed, 2 skipped; 11 integration tests deselected.
The combined Cards and Card author acceptance suite passed 61 tests. Strict SPA checks, 543 SPA tests including OpenAPI parity,
mypyand the SPA build passed. The AST knowledge graph was updated.A live Chrome pass verified Global file editing and saving, Bundled read-only behavior, invalid-definition diagnostics, shared toggles, Profile Disable/Suppression and deletion of a Card whose declared name contains
/. Console and network errors were empty. Independent Standards and Spec reviews of the final diff found no outstanding findings.AI assistance
Implemented and reviewed with Codex. This is a draft PR for human ownership review.