Repository navigation
Conversation
Lancetnik
added this pull request to stack #131
October 6, 2026 19:37
Branch coverage
44 files skipped due to complete coverage. |
This was referenced Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A useful rendered Card could only be revisited through its Chat. Add an explicit Save instance action that captures the complete displayed layout and current local values into an independent
.card-instance.yamlfile, after the user confirms its filename and Directory. Save definition remains a separate action.FilesTree opens saved instances with the shared Card renderer in passive mode. Inputs and nested actions are disabled; the existing source editor retains its ETag conflict and unsaved-change flows. Saved copies remain readable after restart, Chat deletion, or catalog changes, and can be edited, moved or copied with ordinary Files controls.
The profile-scoped API validates self-contained primitive layouts and confines paths to Files. Creation is atomic and never overwrites a destination. Stable request receipts preserve retries across restarts, edits and ordinary file copies. A typed save event records confirmation once; if recording fails after the file is created, the UI reports that state and retries the same frozen request.
Stack: #129 → #130 → #132 → this PR. Base:
feat/cards-settingsat122eb90983e6144e873acac52b073512f27c8a93. The diff contains only the instance feature and its supporting tests/docs.Related issue number
Related to #86; implements the revised independent-copy model in ADR 0043. The original issue's automatic exports and live Chat/file relationship were replaced by the agreed specification.
Checks
ruff check .,ruff format --check ., andpytest -m "not integration"locally and they pass.web/, I rebuilt and committed the SPA bundle (npm --prefix web run build).Validation: 2378 Python tests passed (2 skipped), 548 SPA tests passed, mypy passed, and Svelte check reported no errors or warnings. After review fixes, the affected API/feedback tests and final SPA checks passed. A live Google Chrome pass verified cancellation, Save as, local and repeated-row values, FilesTree opening, passive controls, reload, source edits, Chat independence, and identical retry payloads through moved-file conflicts. DevTools console/network monitoring found no runtime errors, unexpected failed requests or preview-triggered actions. Standards and Spec reviews have no remaining findings.
AI assistance
Significant implementation, tests, documentation and PR drafting assistance from Codex. Two separate agents reviewed Standards and Spec; their findings were fixed and rechecked. The checks below reflect the agent's review and validation, not a claim of the maintainer's personal review.