Skip to content

[Hotfix] Threading and Logging #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MJC598 merged 12 commits into from
Oct 7, 2026
Merged

[Hotfix] Threading and Logging #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
25229bb
adding mermaid docs for dependency inversion and ioc
MJC598 Sep 22, 2026
3cfcdda
Adding updates for execution config and logging config to improve con…
MJC598 Sep 22, 2026
0d30b32
Removing the eager warning log for adding timesteps. We instead want …
MJC598 Sep 22, 2026
9421685
fixing move/copy semantics
MJC598 Sep 22, 2026
d776ad4
Fixing the CMake build for exporting all public headers and fixing th…
MJC598 Sep 23, 2026
ff6e057
updating install location, shared sink ambiguity, history insert orde…
MJC598 Sep 24, 2026
3d8e449
updating documentation
MJC598 Sep 24, 2026
3041910
Updating documentation for true behavior
MJC598 Sep 24, 2026
f2f143e
matrix validation, missing loggers, and simulation durations
MJC598 Sep 24, 2026
ec38bcc
Fixing Eigen thread race conditions between simulations
MJC598 Sep 24, 2026
d5bb07a
linting
MJC598 Sep 24, 2026
c17c10e
Addressing comments in PR with YouTrack Issue SOF-72
MJC598 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,13 @@ target_sources(respond_model
FILES
include/respond/constants.hpp
include/respond/cost_effectiveness.hpp
include/respond/execution_config.hpp
include/respond/history.hpp
include/respond/logging.hpp
include/respond/logging_config.hpp
include/respond/model.hpp
include/respond/respond.hpp
include/respond/runtime_config.hpp
include/respond/simulation.hpp
include/respond/timestep.hpp
include/respond/transition.hpp
Expand All @@ -112,6 +115,7 @@ target_sources(respond_model
# Linking Libraries
#-------------------------------------------------------------------------------
include(${PRIVATE_MODULE_PATH}/MakeDependenciesAvailable.cmake)
find_package(Threads REQUIRED)
set(private_deps spdlog::spdlog)
if (RESPOND_CALCULATE_COVERAGE)
list(APPEND private_deps gcov)
Expand All @@ -120,6 +124,7 @@ endif()
target_link_libraries(respond_model
PUBLIC
Eigen3::Eigen
Threads::Threads
PRIVATE
${private_deps}
)
Expand Down
3 changes: 1 addition & 2 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"RESPOND_CALCULATE_COVERAGE": "OFF",
"RESPOND_BUILD_DOCS": "OFF",
"RESPOND_INSTALL": "OFF",
"RESPOND_SYSTEM_INCLUDES": "OFF",
"RESPOND_NO_EXCEPTIONS": "OFF"
"RESPOND_SYSTEM_INCLUDES": "OFF"
}
},
{
Expand Down
10 changes: 5 additions & 5 deletions cmake/InstallRespond.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ message(STATUS "Installing respond version ${RESPOND_VERSION} to ${CMAKE_INSTALL
# CMAKE_INSTALL_PREFIX variable.
install(TARGETS respond_model
EXPORT respondTargets
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
RUNTIME DESTINATION bin
INCLUDES DESTINATION include
FILE_SET HEADERS DESTINATION include
INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
FILE_SET HEADERS DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
)

include(CMakePackageConfigHelpers)
Expand Down Expand Up @@ -38,7 +38,7 @@ configure_file(

# Define where to install the config files and install the targets before the
# config files. This is so that the config files can actually find the targets
set(ConfigPackageLocation lib/cmake/respond)
set(ConfigPackageLocation ${CMAKE_INSTALL_LIBDIR}/cmake/respond)
install(
EXPORT respondTargets
FILE respondTargets.cmake
Expand Down
3 changes: 1 addition & 2 deletions cmake/options.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ option(RESPOND_CALCULATE_COVERAGE "Calculate Code Coverage" OFF)
# bench options
option(RESPOND_BUILD_BENCH "Build benchmarks" OFF)

# compile level warning and exception options
# compile level warning options
option(RESPOND_BUILD_WARNINGS "Enable compiler warnings" OFF)
option(RESPOND_NO_EXCEPTIONS "Compile with -fno-exceptions. Call abort() on any simdemics exceptions" OFF)
Comment thread
ddbaptiste marked this conversation as resolved.

# install options
option(RESPOND_SYSTEM_INCLUDES "Include as system headers (skip for clang-tidy)." OFF)
Expand Down
Loading
Loading