Skip to content

[Hotfix] Threading and Logging - #157

Merged
MJC598 merged 12 commits into
mainfrom
hotfix/logging-issues
Oct 7, 2026
Merged

MJC598 merged 12 commits into
mainfrom
hotfix/logging-issues

Conversation

@MJC598

@MJC598 MJC598 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR addresses a lot of things, mostly dealing with either some part of threading or logging.

  1. Threads can now be specified to either run models concurrently or put threads towards Eigen
  2. The move assignment operators now actually move items rather than copy them. This was propagated down through the entire project.
  3. CMake properties were changed to GNUInstallDirs
  4. Logging was given mutexes so that we can share sinks without race conditions
  5. Discounting is now multiplying the discount to remove rather than subtracting the discounting rate from the value
  6. Timestep inserts was updated to correctly insert in order
  7. Documentation was updated throughout
  8. Tons of new tests

What Wrike task is this associated with?

Don't you mean YouTrack? :)

Checklist before merging

  • If adding a core feature, I've added related tests.
  • This is part of a product update, and I've added an explanation of what is different to the changelog.

@MJC598 MJC598 self-assigned this Sep 24, 2026
@MJC598
MJC598 requested a review from a team as a code owner September 24, 2026 16:56
@MJC598 MJC598 added the bug Something isn't working label Sep 24, 2026
@MJC598
MJC598 requested a review from ddbaptiste as a code owner September 24, 2026 16:56
@MJC598 MJC598 added the enhancement New feature or request label Sep 24, 2026
@MJC598

MJC598 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Testing if we can link SOF-72 from YouTrack.

@ddbaptiste ddbaptiste left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and a handful of requested changes. This is a lot to get my head around, but I like the idea of the functionality you're adding.

Comment thread cmake/options.cmake
Comment thread docs/src/api-guide.md
Comment thread docs/src/api-guide.md
Comment thread docs/src/ioc.mmd
Comment thread include/respond/simulation.hpp
Comment thread include/respond/simulation.hpp Outdated
Comment thread src/internals/markov.hpp
Comment thread src/logging.cpp
@MJC598
MJC598 merged commit 1ef0521 into main Oct 7, 2026
6 checks passed
@MJC598
MJC598 deleted the hotfix/logging-issues branch October 7, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants