Skip to content

OMBackend 0.11.1: fixes from the OM.jl suite - #106

Merged
JKRT merged 1 commit into
OpenModelica:masterfrom
JKRT:omjl-suite-fixes
Nov 17, 2026
Merged

JKRT merged 1 commit into
OpenModelica:masterfrom
JKRT:omjl-suite-fixes

Conversation

@JKRT

@JKRT JKRT commented Nov 17, 2026

Copy link
Copy Markdown
Member

Fixes for the OM.jl suite on 0.11.0 (local run: 24 failed, 49 errored).

  • A DAE solver on the array code: the ODE in residual form (ode_to_dae, no n x n mass matrix), BrownFullBasicInit after events.
  • Event functions (floor, mod, ...) literal at events, as omc's _event_floor: PersonalityAspects chattered at t = 24.
  • Models with relations: largest step 9/500 of the span, 10 checks per step (a 0.31 s window was stepped over).
  • A small loop that divides by one of its unknowns is torn (MSL HeatingRectifier: NaN from a guess of 0).
  • Backend scalarization: one when-trigger per element of a vector condition; for-statement iterators shadow variables of their name; val[idx, :] by a discrete index.
  • Array code: calls returning arrays of records as arguments; initial arms of lifted clusters first; enumeration literals in String(); parameters in SymbolicIndexingInterface (sol.ps).

Tests: arrayPathTests (DivideInLoop, ShortWindow, ModDay, DAEIfReinit, TableRow, EnumerationString, RecordArrayCall, TwoTables), indexReductionTests (elementTriggers, isBoundIterator).
Tests: OMBackend 2643/2643 (local, warm).
Goes with OMFrontend 2.2.2 (OpenModelica/OMFrontend.jl#117); CI takes JKRT/OMFrontend.jl@omjl-suite-fixes.
Version 0.11.1.

Assisted-by: Claude Opus 5.5

- DAE solvers on the array code: residual form, BrownFullBasicInit.
- Event functions literal at events (omc _event_floor).
- Models with relations: largest step 9/500 of the span.
- A small loop that divides by one of its unknowns is torn.
- Backend scalarization: per-element when-triggers, for-iterator
  scoping, val[idx, :] by a discrete index.
- Array code: record-array call arguments, initial arms of lifted
  clusters first, enumeration literals in String(), sol.ps.

Assisted-by: Claude Opus 5.5
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.15%. Comparing base (48757b0) to head (c152bbf).
⚠️ Report is 64 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #106       +/-   ##
===========================================
+ Coverage   24.78%   83.15%   +58.37%     
===========================================
  Files          28      114       +86     
  Lines        3430    34247    +30817     
===========================================
+ Hits          850    28477    +27627     
- Misses       2580     5770     +3190     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JKRT

JKRT commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

Might fail due to memory issue on the mac runner. Should be fine anyway. Will fix in separate PRs

@JKRT
JKRT merged commit 3ccde41 into OpenModelica:master Nov 17, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant