Repository navigation
OMBackend 0.11.1: fixes from the OM.jl suite - #106
Merged
Merged
Conversation
- DAE solvers on the array code: residual form, BrownFullBasicInit. - Event functions literal at events (omc _event_floor). - Models with relations: largest step 9/500 of the span. - A small loop that divides by one of its unknowns is torn. - Backend scalarization: per-element when-triggers, for-iterator scoping, val[idx, :] by a discrete index. - Array code: record-array call arguments, initial arms of lifted clusters first, enumeration literals in String(), sol.ps. Assisted-by: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
===========================================
+ Coverage 24.78% 83.15% +58.37%
===========================================
Files 28 114 +86
Lines 3430 34247 +30817
===========================================
+ Hits 850 28477 +27627
- Misses 2580 5770 +3190 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Might fail due to memory issue on the mac runner. Should be fine anyway. Will fix in separate PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the OM.jl suite on 0.11.0 (local run: 24 failed, 49 errored).
ode_to_dae, no n x n mass matrix), BrownFullBasicInit after events.floor,mod, ...) literal at events, as omc's_event_floor: PersonalityAspects chattered at t = 24.val[idx, :]by a discrete index.sol.ps).Tests: arrayPathTests (DivideInLoop, ShortWindow, ModDay, DAEIfReinit, TableRow, EnumerationString, RecordArrayCall, TwoTables), indexReductionTests (
elementTriggers,isBoundIterator).Tests: OMBackend 2643/2643 (local, warm).
Goes with OMFrontend 2.2.2 (OpenModelica/OMFrontend.jl#117); CI takes JKRT/OMFrontend.jl@omjl-suite-fixes.
Version 0.11.1.
Assisted-by: Claude Opus 5.5