Repository navigation
OMBackend 0.11.2: suite time — no deprecated calls, one build per comparison, platform group on mac/Windows - #107
Merged
Merged
Conversation
u_modified! -> SciMLBase.derivative_discontinuity! (the alias for older SciMLBase removed), solve_for -> symbolic_linear_solve (SciMLBase 3, Symbolics 7 renames; same semantics). Under --depwarn=yes, as Pkg.test runs, each deprecated call takes a backtrace (~0.3 ms): 1000 sample events solved in 0.64 s instead of 0.03 s on the array code. Assisted-by: Claude Opus 5.5
…orm group _bothWays/_bothWaysOf read the scalarizing path's values from test/arrayPathReferences.jl (137 entries) instead of building each model twice; a missing entry builds it, fails and prints the entry. OMBACKEND_TEST_GROUP "platform" leaves out arrayPathTests.jl (~80% of the suite's time); CI runs it on macOS and Windows, the whole suite on Linux. Assisted-by: Claude Opus 5.5
A 2021 hand-written DAE script (OpenModelica#25), not referenced anywhere. Assisted-by: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
===========================================
+ Coverage 24.78% 81.64% +56.86%
===========================================
Files 28 114 +86
Lines 3430 34202 +30772
===========================================
+ Hits 850 27925 +27075
- Misses 2580 6277 +3697 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mac job timed out at 90 min since 0.11.0 (#106: Ubuntu 49 min of tests, mac about 2.3x that).
u_modified!→SciMLBase.derivative_discontinuity!,solve_for→symbolic_linear_solve(renames, samesemantics). Under Pkg.test's
--depwarn=yeseach deprecated call took a backtrace (~0.3 ms): 1000 sample events0.64 s instead of 0.03 s.
test/arrayPathReferences.jl(137 entries); eachmodel is built once. A comparison without an entry fails and prints the entry.
OMBACKEND_TEST_GROUP=platformleaves outarrayPathTests.jl(80% of the suite's time). CI: whole suite andcoverage on Linux, the platform group on macOS and Windows.
scratch/simple.jl(2021, unreferenced).Local, fresh process, 1 thread,
--depwarn=yes(macOS, arm64):Array path testset: 835 s → 501 s.