Skip to content

Confirm the overall formatting sweep is complete #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ostomachion merged 1 commit into from
Sep 22, 2026
Merged

Confirm the overall formatting sweep is complete #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions docs/foundation-checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,9 +444,10 @@ or editor rehearsal was performed.
- [x] Share configurations between editor, optional hooks, command line, and CI.
Exclude generated artifacts, dependencies, and vendored skills; avoid competing
formatters for a file type.
- [ ] Publish the initial formatting sweep as a separate PR. It is isolated in
local commit `1f646a6` on `codex/foundation-formatting-sweep`; tooling follows
on `codex/foundation-section-14-content`. Neither branch has been published.
- [x] Publish and verify the initial formatting sweep. Formatting commit `1f646a6`
was included with the tooling in [PR #114](https://github.com/OpenGameBuilder/opengamebuilder/pull/114).
Rerunning the configured formatters on merged `main` (`f8db700`) produced no
changes; the originally planned separate mechanical PR has no remaining diff.

**Acceptance:** deliberate formatting, Markdown-structure, missing-target/anchor,
workflow, and shell defects fail their appropriate checks with clear fixes. Clean
Expand All @@ -458,15 +459,19 @@ Sources: [Prettier](https://prettier.io/docs/install),
[ShellCheck](https://github.com/koalaman/shellcheck), [shfmt](https://github.com/mvdan/sh),
[lychee](https://lychee.cli.rs/guides/cli/).

**Result (2026-09-22, local implementation complete):** The
**Result (2026-09-22, implementation and formatting acceptance complete):** The
[shared content workflow](quality/content-checks.md) pins and verifies the tools,
preserves formatter ownership, checks local links offline, and schedules bounded
external reports. The full Windows gate passed with zero build warnings and 72
.NET tests; all seven content regression groups and the final content gate passed.
[Validation evidence](quality/content-checks.md#recorded-validation) records the
injected C# failures, installer checks, and narrow actionlint cache-mode exception.
Linux execution, hosted CI, the scheduled report, and separate PR publication
remain unverified. No application services or deployments were started.
The [Ubuntu CI gate](https://github.com/OpenGameBuilder/opengamebuilder/actions/runs/35744440511/job/106802281361)
also passed content checks, all seven regression groups, and the full solution
gate for the exact tree merged in PR #114. A fresh Windows formatter pass over
that merged tree produced no changes. The external-link schedule has not yet run;
it is separate from the required formatting and local-link gate. No application
services or deployments were started by this formatting verification.

### 15. Validate the supported platform and keep CI understandable

Expand Down
16 changes: 12 additions & 4 deletions docs/quality/content-checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,18 @@ is enforced by formatting verification, not by this SDK's build analyzer. Native
tool installation, reuse without downloads, and rejection of a corrupted
executable were verified on Windows.

Linux asset and executable checksums were verified, but Linux execution and hosted
CI remain unverified. The external-link schedule has not run from this change.
These checks did not start application services, deploy, or establish browser
acceptance. The initial mechanical formatting sweep is kept separate for review.
The [Ubuntu 24.04 CI gate for PR #114](https://github.com/OpenGameBuilder/opengamebuilder/actions/runs/35744440511/job/106802281361)
also passed the content checks, all seven regression groups, and the full solution
gate. The tree tested at `d5e0bb6` exactly matches merge commit `f8db700` on `main`,
including the initial mechanical formatting commit `1f646a6`.

After the merge, `pwsh ./scripts/check.ps1 format -Fix -Serial` was rerun on Windows
against `f8db700`. C# formatting, Prettier, and shfmt all completed successfully;
`git diff --exit-code` confirmed that the overall sweep produced no changes.
The separate mechanical PR originally planned is therefore already covered by
[the merged PR](https://github.com/OpenGameBuilder/opengamebuilder/pull/114).
The external-link schedule has not yet run. These formatting checks did not start
application services, deploy, or establish browser acceptance.

## Local links and external maintenance

Expand Down
Loading