Skip to content

fix(sasayaki): add media notification actions#75

Open
veritablevein wants to merge 1 commit into
HuangAntimony:mainfrom
veritablevein:codex/sasayaki-media-actions-minimal
Open

fix(sasayaki): add media notification actions#75
veritablevein wants to merge 1 commit into
HuangAntimony:mainfrom
veritablevein:codex/sasayaki-media-actions-minimal

Conversation

@veritablevein

Copy link
Copy Markdown

Summary

  • add concrete media notification actions for previous/play-pause/next
  • keep the compact media style indices aligned with the actions actually added to the notification
  • route notification actions to the existing Sasayaki playback callbacks

This is a smaller replacement for #72 that removes the settings toggle and device-specific fallback now that the SystemUI crash was traced to the incomplete media notification actions.

Testing

  • ./gradlew test
  • ./gradlew assembleDebug
  • ./gradlew lint
  • Tested on Hisense A5 Pro / Android 10: media notification no longer triggers the lock-screen sleep, and previous/play-pause/next controls work.

@HuangAntimony

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d775a2022c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +167 to +168
actions.forEach { action ->
builder.addAction(action.toNotificationCompatAction(appContext, session.id))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add required Sasayaki release docs

This adds user-visible Sasayaki notification controls, but the commit leaves docs/CHANGELOG.md's [Unreleased] section empty and does not update docs/TODO.md. The repo instructions in AGENTS.md require user-visible fixes/features to be recorded in the changelog and TODO to be updated in the same commit, so this release would otherwise omit the fix from user-facing notes and current project status.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants