Skip to content

fix(sasayaki): publish complete system media controls#72

Closed
veritablevein wants to merge 2 commits into
HuangAntimony:mainfrom
veritablevein:codex/sasayaki-media-controls-compat
Closed

fix(sasayaki): publish complete system media controls#72
veritablevein wants to merge 2 commits into
HuangAntimony:mainfrom
veritablevein:codex/sasayaki-media-controls-compat

Conversation

@veritablevein

@veritablevein veritablevein commented May 17, 2026

Copy link
Copy Markdown

Fix the Sasayaki media notification so Android SystemUI receives a complete, self-consistent set of media actions instead of compact action indices without matching notification actions.

The Hisense A5 Pro / Android 10 lock-screen sleep was caused by the OEM SystemUI crashing while inflating the Sasayaki media notification. The previous workaround disabled the notification path in Auto mode on that device. This update keeps system media controls enabled in Auto and fixes the notification structure directly:

  • add explicit Previous / Play-Pause / Next notification actions before using them in setShowActionsInCompactView
  • route notification button taps back to the existing Sasayaki cue/playback callbacks, so Next Cue does not depend on platform skipToNext() playlist semantics
  • keep the Auto / On / Off setting, with Off as a manual fallback if another device-specific SystemUI issue appears later
  • update docs and tests to reflect that Auto now publishes usable system media controls

Verified:

  • ./gradlew test
  • ./gradlew assembleDebug
  • ./gradlew lint
  • Real Hisense A5 Pro Android 10: Auto shows media controls without lock-screen sleep; notification Previous, Play/Pause, and Next controls work; Off suppresses the media notification fallback.

Add an Auto/On/Off Sasayaki System Media Controls setting and suppress the media notification on Hisense HLTE203T Android 10 in Auto mode to avoid the OEM SystemUI notification inflation crash that forces the app into lock-screen sleep.

Verified with ./gradlew test assembleDebug lint and real-device A5 Pro checks: Auto and Off avoid lock-screen sleep; On reproduces the SystemUI crash.
@veritablevein veritablevein changed the title fix(sasayaki): guard system media controls on unstable devices fix(sasayaki): publish complete system media controls May 18, 2026
@veritablevein

Copy link
Copy Markdown
Author

Superseded by #75, which keeps the fix minimal and only changes the media notification actions needed to resolve the SystemUI crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant