Skip to content

docs(bench): /v1/history comments still called it a proposal #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinmintdev merged 1 commit into from
Aug 10, 2026
Merged

docs(bench): /v1/history comments still called it a proposal #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/lib/bench-view.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,14 +863,14 @@ export function laneMarkerShape(lane) {
}

/**
* Parse the proposed `GET /v1/history?model=<id>&lane=<lane>` response (an
* adapter-only endpoint today — no production worker route yet; see
* bench-live-adapter.mjs's /v1/history passthrough and this repo's PR body
* for the proposed worker contract addition) into a validated points array
* for the drawer's decode-history graph.
*
* Filtered server-side by DISPLAY DIMS (model, lane — kind='tg', outcome
* 'ok') rather than by cell_key: a cell_key is a content-addressed
* Parse a `GET /v1/history?model=<id>&lane=<lane>&kind=tg&config=<variant>`
* response into a validated points array for the drawer's decode-history
* graph. A real worker route (workers/bench-api registers it alongside
* roster/evals/runs); bench-live-adapter.mjs stands in for it against CT105
* in the dev preview.
*
* Filtered server-side by DISPLAY DIMS (model, lane, kind, config) rather
* than by cell_key: a cell_key is a content-addressed
* identity, so an engine/image provenance bump between two sweeps forks the
* key and turns what should be one continuous history into several
* one-point series — the hal0 dashboard hit exactly this and moved its own
Expand Down
5 changes: 2 additions & 3 deletions src/scripts/bench-island.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,8 @@ function drawerThrottleHtml(): string {

// drawerModel.hasHistory/row.history stay unused — no data path populates
// BenchRow.history yet (see bench-view.mjs's typedef). The graph below is a
// SEPARATE data path: a per-request fetch of the proposed
// `/v1/history?model=&lane=` endpoint (see fetchRunHistory), not
// drawerModel's `history` field.
// SEPARATE data path: a per-request fetch of the `/v1/history` endpoint (see
// fetchRunHistory), not drawerModel's `history` field.

const SPARK_ESC_MAP: Record<string, string> = { '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' };
const svgEsc = (s: unknown) => String(s ?? '').replace(/[&<>"']/g, (c) => SPARK_ESC_MAP[c]);
Expand Down
Loading