docs(bench): /v1/history comments still called it a proposal - #105
Merged
Conversation
Two comment blocks outlived #63 and #104 — normalizeHistoryPoints' docstring and the run-drawer graph note both described /v1/history as proposed and adapter-only, and the docstring listed the old display dims (kind/outcome hardcoded) rather than the kind/config the caller now pins. Comments only, no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying hal0-web with
|
| Latest commit: |
5487575
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba0e364e.hal0-web.pages.dev |
| Branch Preview URL: | https://docs-bench-history-comment-d.hal0-web.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment drift left behind by #63 and #104. No behaviour change.
Two blocks still described
/v1/historyas a proposed, adapter-only endpoint:bench-view.mjs—normalizeHistoryPoints' docstring, which additionally listed the old display dims (kind='tg',outcome='ok'as fixed server-side facts) rather than thekind/configthe caller now pins since fix(bench): decode-history graph plotted prefill runs as decode points #104bench-island.ts— the run-drawer graph noteFound by sweeping for
proposed|adapter-onlyacrosssrc/andworkers/after the merges; that sweep is now clean.Verification: 223 tests pass, 0 skipped, after
npm run build.🤖 Generated with Claude Code