Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1355.
Regression evidence
Before:
uv run pytest tests/test_agents.py::test_filecheck_warns_about_previously_failed_documents -qexited1After:
uv run pytest tests/test_agents.py::test_filecheck_warns_about_previously_failed_documents -qexited0Verification
uv run pytest tests/test_agents.py::test_filecheck_warns_about_previously_failed_documents tests/test_agents.py::test_getting_manifest tests/test_agents.py::test_settings_model_config tests/test_agents.py::test_tool_schema tests/test_agents.py::test_empty_index_without_index_rebuild -quv run prek run --all-filesuv run pylint src packagesuv run refurb .uv build --package paper-qaThe broader index-build tests require the external model credentials documented in
CONTRIBUTING.md. I attempted them locally, but they stopped in the unchanged OpenAI client setup because no key is available; I have not counted those runs as passing. The focused regression and the five credential-free agent/index tests above cover the changed decision path.Scope