Skip to content

Fix foxglove messages build issue #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanaelren merged 2 commits into from
Jul 8, 2026
+6 −3
Merged

Fix foxglove messages build issue #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bd8ea4
Fix foxglove messages build issue
maxwellmlin Jul 8, 2026
ff1525d
Also use suffix filter (we were pulling in some false positives before)
maxwellmlin Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions foxglove/shared/defs/src/generateRosTsGeneratorConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { readdirSync, statSync, writeFileSync } from "fs";
import { existsSync, readdirSync, statSync, writeFileSync } from "fs";
import { join } from "path";

/**
Expand All @@ -21,8 +21,11 @@ export function generateRosTsGeneratorConfig(
.map((name) => join(rosSharePath, name))
.filter((path) => statSync(path).isDirectory());

// Filter directories to only include those ending in '_srvs' or '_msgs'
const filteredDirectories = allDirectories.filter((dir) => dir.endsWith("_srvs") || dir.endsWith("_msgs"));
const filteredDirectories = allDirectories.filter(
(dir) =>
(dir.endsWith("_srvs") || dir.endsWith("_msgs") || dir.endsWith("_interfaces")) &&
(existsSync(join(dir, "msg")) || existsSync(join(dir, "srv"))),
);

// Create the JSON configuration object
const outputData = {
Expand Down
Loading