Fix foxglove messages build issue - #121
Merged
Merged
Conversation
Include every package that actually defines messages or services rather then use the previous suffix heuristic.
Member
Author
|
Should be fine to merge as long as all checks pass. |
nathanaelren
self-requested a review
July 8, 2026 17:25
nathanaelren
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: we generate our ROS TypeScript types from source (whatever ROS is currently installed in the container) whenever we do
fox build. For more active frontend teams, the better pattern would probably be to commit these types and have someone rebuild/review the updated types regularly. However, I automated this process during the ROS 2 migration since we don't have an active frontend team to do this. This means that if ROS adds new message definitions, the build may occasionally break and you may have to do a fix like this...