RUM-17613: timeseries [4/5] Flush the batch in background - #3719
Merged
satween merged 2 commits intoAug 18, 2026
Merged
Conversation
🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: febc38d | Docs | View more details | Give us feedback! |
satween
force-pushed
the
tvaleev/feature/RUM-17613-3b-background-suspend
branch
from
August 17, 2026 08:55
40a19e5 to
57ac354
Compare
3 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
satween
force-pushed
the
tvaleev/feature/RUM-17613-3b-background-suspend
branch
2 times, most recently
from
August 17, 2026 10:45
8f84420 to
a689c33
Compare
satween
marked this pull request as ready for review
August 17, 2026 10:55
satween
force-pushed
the
tvaleev/feature/RUM-17613-3b-background-suspend
branch
from
August 17, 2026 12:05
a689c33 to
369a5ee
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 369a5eee5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Base automatically changed from
tvaleev/feature/RUM-17613-3-background-flush
to
feature/timeseries
August 17, 2026 12:46
Sampling kept running while the app sat in background, and the buffered batch was only written on session stop, so points collected before a backgrounding could stay unsent for the rest of the session. The collector now suspends the sampling chain when the active view leaves the foreground and flushes the buffers at that point, attributing the batch to the last foreground context. The suspension is delayed by 200 ms to match ActivityViewTrackingStrategy.STOP_VIEW_DELAY_MS, so an Activity-to-Activity transition is not mistaken for a backgrounding. Sampling state carries a generation counter so a suspension pending on an older generation cannot stop a chain that has since been resumed. Drops TimeseriesConfiguration.collectInBackground: background suspension is now unconditional, so the flag no longer has a meaning. Ref: RUM-17613
satween
force-pushed
the
tvaleev/feature/RUM-17613-3b-background-suspend
branch
from
August 17, 2026 12:46
369a5ee to
2f61d4f
Compare
0xnm
reviewed
Aug 18, 2026
Comment on lines
85
to
+55
| val isEnterForeground = !oldViewType.isForeground && newViewType.isForeground | ||
| val isLeaveForeground = oldViewType.isForeground && !newViewType.isForeground |
Member
There was a problem hiding this comment.
Maybe it is worth to add a callback to the ProcessLifecycleMonitor? Although this approach probably also works.
Contributor
Author
There was a problem hiding this comment.
Yes, but as long as we catching the rumContext which is required to build proper timeseries batch event - I prefer to keep the existing logic for now. Plus it allows to catch a specific scenario, when app is not fully in foreground, but starting (APPLICATION_LAUNCH) which could be very important for the timeseries
The pending suspend read lastForegroundRumContext at fire time, so a foreground re-entry landing between stopGeneration() and the flush made it attribute the previous view's batch to the new view. Snapshot the context when the stop is scheduled instead.
0xnm
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes timeseries not being sent when the app goes to background with a partially filled batch.
Sampling used to keep running in background (unless
collectInBackgroundwas off) and the buffer was only written on session stop, so points collected before a backgrounding could stay unsent for the rest of the session. Now, when the active view leaves the foreground, the collector suspends the sampling chain and flushes the buffers, attributing the batch to the last foreground context — a background flush has no view of its own to attribute to.The suspension is delayed by 200 ms to match
ActivityViewTrackingStrategy.STOP_VIEW_DELAY_MS: an Activity-to-Activity transition leaves no active view for a moment and must not be mistaken for a backgrounding. If the app returns to the foreground within that window, collection simply continues. Sampling state carries a generation counter so a suspension pending on an older generation cannot stop a chain that has since been resumed.TimeseriesConfiguration.collectInBackgroundis dropped: background suspension is now unconditional, so the flag no longer has a meaning.Review checklist (to be filled by reviewers)
Ref: RUM-17613